Merge pull request #80 from bepoli/fix_remove_links

Fix links not removed after uninstalling package
mariusvniekerk · Aug 8, 2024 · 5260187 · 5260187
2 parents 6e31d0b + 2e46075
commit 5260187
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 1 deletion.
diff --git a/condax/core.py b/condax/core.py
@@ -147,7 +147,7 @@ def remove_links(executables_to_unlink: Collection[Path], env_prefix: Path) -> N
             os.unlink(link)
             removed_links[exe] = link
         else:
-            if os.path.islink(link) and (os.readlink(link) == exe):
+            if os.path.islink(link) and (os.readlink(link) == str(exe)):
                 os.unlink(link)
                 removed_links[exe] = link
 

diff --git a/news/fix_remove_links.md b/news/fix_remove_links.md
@@ -0,0 +1,23 @@
+### Added:
+
+* <news item>
+
+### Changed:
+
+* <news item>
+
+### Deprecated:
+
+* <news item>
+
+### Removed:
+
+* <news item>
+
+### Fixed:
+
+* Fix links not removed after uninstalling package
+
+### Security:
+
+* <news item>