Fix plugin to run on current versions of Obsidian. #3
+200
−115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ackages and build to the latest versions.
# Conflicts: # src/ConfluencePerPageForm.tsx
|
What needs to be done to get this merged/fixed? Just got obsidian to work with confluence and found the plugin is busted. |
|
It appears the project is abandoned, last commit over a year ago. |
|
Considering this project seems to be abandoned, could you @jcfergus post basic instructions on how to install this manually? |
|
You can install with BRAT with : https://github.com/lucasiscovici/obsidian-integration/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the dependencies and code to use the latest Obisdian sample plugin as a base, to solve these errors preventing the plugin from being enabled on recent versions of Obsidian.
i.e. markdown-confluence/markdown-confluence#651
I have tested it successfully on Obsidian 1.7.4, I don't know about other versions. There are no actual code changes in src/ConfluencePerPageForm.tsx, beyond adding some explicit
anytypes in a few spots to get eslint/tsc to not complain about them - my IDE "fixed" a few indents. I can revert those indentation changes if needed.