Skip to content

Commit

Permalink
fix tests
Browse files Browse the repository at this point in the history
  • Loading branch information
markdroth committed Dec 26, 2024
1 parent 0b1454e commit 425434a
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 10 deletions.
2 changes: 1 addition & 1 deletion test/cpp/end2end/rls_end2end_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -1373,7 +1373,7 @@ TEST_F(RlsEnd2endTest, ConnectivityStateTransientFailure) {
BuildRlsResponse({"invalid_target"}));
CheckRpcSendFailure(
DEBUG_LOCATION, StatusCode::UNAVAILABLE,
"empty address list: no address in fixed_address_lb policy",
"empty address list (no address in fixed_address_lb policy)",
RpcOptions().set_metadata({{"key1", kTestValue}}));
EXPECT_EQ(rls_server_->service_.request_count(), 1);
EXPECT_EQ(rls_server_->service_.response_count(), 1);
Expand Down
4 changes: 2 additions & 2 deletions test/cpp/end2end/xds/xds_cluster_type_end2end_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -798,8 +798,8 @@ TEST_P(AggregateClusterTest, ReconfigEdsWhileLogicalDnsChildFails) {
}
// When an RPC fails, we know the channel has seen the update.
constexpr char kErrorMessage[] =
"empty address list: DNS resolution failed for server.example.com:443: "
"UNAVAILABLE: injected error";
"empty address list \\(DNS resolution failed for server.example.com:443: "
"UNAVAILABLE: injected error\\)";
CheckRpcSendFailure(DEBUG_LOCATION, StatusCode::UNAVAILABLE, kErrorMessage);
// Send an EDS update that moves locality1 to priority 0.
args1 = EdsResourceArgs({
Expand Down
8 changes: 4 additions & 4 deletions test/cpp/end2end/xds/xds_csds_end2end_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -723,8 +723,8 @@ TEST_P(CsdsShortAdsTimeoutTest, XdsConfigDumpListenerDoesNotExist) {
balancer_->ads_service()->UnsetResource(kLdsTypeUrl, kServerName);
CheckRpcSendFailure(
DEBUG_LOCATION, StatusCode::UNAVAILABLE,
absl::StrCat("empty address list: LDS resource ", kServerName,
": does not exist \\(node ID:xds_end2end_test\\)"),
absl::StrCat("empty address list \\(LDS resource ", kServerName,
": does not exist \\(node ID:xds_end2end_test\\)\\)"),
RpcOptions().set_timeout_ms(kTimeoutMillisecond));
auto csds_response = FetchCsdsResponse();
EXPECT_THAT(csds_response.config(0).generic_xds_configs(),
Expand All @@ -740,9 +740,9 @@ TEST_P(CsdsShortAdsTimeoutTest, XdsConfigDumpRouteConfigDoesNotExist) {
kDefaultRouteConfigurationName);
CheckRpcSendFailure(
DEBUG_LOCATION, StatusCode::UNAVAILABLE,
absl::StrCat("empty address list: RDS resource ",
absl::StrCat("empty address list \\(RDS resource ",
kDefaultRouteConfigurationName,
": does not exist \\(node ID:xds_end2end_test\\)"),
": does not exist \\(node ID:xds_end2end_test\\)\\)"),
RpcOptions().set_timeout_ms(kTimeoutMillisecond));
auto csds_response = FetchCsdsResponse();
EXPECT_THAT(
Expand Down
6 changes: 3 additions & 3 deletions test/cpp/end2end/xds/xds_fallback_end2end_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -147,11 +147,11 @@ TEST_P(XdsFallbackTest, PrimarySecondaryNotAvailable) {
CheckRpcSendFailure(
DEBUG_LOCATION, StatusCode::UNAVAILABLE,
absl::StrFormat(
"empty address list: LDS resource server.example.com: "
"empty address list \\(LDS resource server.example.com: "
"xDS channel for server localhost:%d: "
"xDS call failed with no responses received; "
"status: RESOURCE_EXHAUSTED: test forced ADS stream failure \\(node "
"ID:xds_end2end_test\\)",
"status: RESOURCE_EXHAUSTED: test forced ADS stream failure "
"\\(node ID:xds_end2end_test\\)\\)",
fallback_balancer_->port()));
}

Expand Down

0 comments on commit 425434a

Please sign in to comment.