Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to [email protected] #61

Merged
merged 7 commits into from
Mar 6, 2020
Merged

Upgrade to [email protected] #61

merged 7 commits into from
Mar 6, 2020

Conversation

markokajzer
Copy link
Owner

@markokajzer markokajzer commented Dec 9, 2019

What has been done

  • Upgrade to discord.js v12
  • Use @discordjs/opus to avoid deprecated and abandoned node-opus package
  • Upgraded to Node v12
  • Add .node-version file

How to test

  • Confirm that every piece of functionality still works as expected
    • Check all commands
    • Check entrance / exit sounds
    • Check all config options

Notes

  • See here for update guide
  • Node v12 (newest) was not possible due to a transitive dependency of node-opus to a package called ref which is incompatible with Node v12
    • This is definitely a reason to ditch node-opus entirely in favor of opusscript
    • opusscript is said to be not very performant in the discord.js docs but how big is the difference? Is it really worth this whole hassle? I couldn't find any mentions of this outside of that README and it has been there since forever. Maybe the issues have been resolved?
    • Could also try ref-napi according to this comment

@markokajzer markokajzer self-assigned this Dec 9, 2019
@markokajzer markokajzer force-pushed the discordjs-v12 branch 2 times, most recently from 947fab1 to ae6e058 Compare January 22, 2020 12:22
@markokajzer
Copy link
Owner Author

It seems like release of discord.js v12 is actually imminent after all this time if we look at their roadmaps and projects, so I'll put this on ice until the release sees the light of day.

@markokajzer markokajzer marked this pull request as ready for review March 3, 2020 19:51
@markokajzer markokajzer force-pushed the discordjs-v12 branch 2 times, most recently from 3916882 to ad6ccb9 Compare March 3, 2020 20:01
@markokajzer markokajzer changed the title Use discord.js@master Upgrade to [email protected] Mar 3, 2020
@markokajzer
Copy link
Owner Author

cc @nstapelbroek LMAO 👌

@markokajzer markokajzer changed the title Upgrade to [email protected] Upgrade to [email protected] Mar 3, 2020
@markokajzer markokajzer merged commit 3f64138 into master Mar 6, 2020
@markokajzer markokajzer deleted the discordjs-v12 branch March 6, 2020 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant