-
Notifications
You must be signed in to change notification settings - Fork 196
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
(releases/2.13) Make compatibility tests run on releases branch and m…
…ake them run on all previous patch versions (#1077)
- Loading branch information
1 parent
2154a17
commit f29fe81
Showing
18 changed files
with
1,778 additions
and
33 deletions.
There are no files selected for viewing
171 changes: 171 additions & 0 deletions
171
.github/workflows/backwards_compatibility_marqo_execution.yml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,171 @@ | ||
# Execution workflow | ||
name: Marqo Compatibility Tests Execution | ||
|
||
on: | ||
workflow_call: | ||
# from_version: Used as: the identifier for a workflow call, for logging purposes and for pulling image from DockerHub. We need to pass a version here: ex: 2.11.1 | ||
# to_version: Used as: the identifier for a workflow call and for logging purposes. We cannot use this to pull images from ECR or DockerHub (as opposed to from_version) since the to_version image has not been released yet. We need to pass a version here: ex: 2.11.5 | ||
# to_image: A unique identifier of the to_version image uploaded to ECR. Can either be the tag or the digest of the "To be released" image. This is specifically used to pull images from ECR. We need to pass a full qualified docker image name with tag or digest here, example: marqoai/marqo:abcd1234 or marqoai/marqo@sha256:1234567890abcdef resp. | ||
inputs: | ||
from_version: | ||
description: 'Source Marqo version. This is calculated in backwards_compatibility_marqo_orchestrator.yml and passed to this workflow' | ||
required: true | ||
type: string | ||
to_version: | ||
description: 'Target Marqo version. This is used for logging purposes, to identify the target version of Marqo being tested and to calculate the from_versions in the backwards_compatibility_marqo_orchestrator.yml. It is NOT used to pull images from ECR.' | ||
required: true | ||
type: string | ||
to_image: | ||
description: 'To version image identifier is a unique identifier for the target Marqo image, which can either be a tag or a digest. It should contain complete qualified image name with tag or digest. For example: marqoai/marqo:abcd1234 or marqoai/marqo@sha256:1234567890abcdef. This is used to pull images from ECR.' | ||
required: true | ||
type: string | ||
mode: | ||
description: 'The mode in which the compatibility tests are to be run. Options: "backwards_compatibility", "rollback"' | ||
required: true | ||
type: string | ||
workflow_dispatch: | ||
# from_version: Used as: the identifier for a workflow call, for logging purposes and for pulling image from DockerHub. We need to pass a version here: ex: 2.11.1 | ||
# to_version: Used as: the identifier for a workflow call and for logging purposes. We cannot use this to pull images from ECR or DockerHub (as opposed to from_version) since the to_version image has not been released yet. We need to pass a version here: ex: 2.11.5 | ||
# to_image: A unique identifier of the to_version image uploaded to ECR. Can either be the tag or the digest of the "To be released" image. This is specifically used to pull images from ECR. We need to pass a full qualified docker image name with tag or digest here, example: marqoai/marqo:abcd1234 or marqoai/marqo@sha256:1234567890abcdef resp. | ||
|
||
# If running manually, just specify the from_version, to_version and the fully qualified marqo image name with tag or digest in same format of the examples given above | ||
inputs: | ||
from_version: | ||
description: 'Source Marqo version. This is used to pull the image from DockerHub and for logging purposes.' | ||
required: true | ||
type: string | ||
to_version: | ||
description: 'Target Marqo version. This is used for logging purposes and to identify the target version of Marqo being tested.' | ||
required: true | ||
type: string | ||
to_image: | ||
description: 'To version image identifier is a unique identifier for the target Marqo image, which can either be a tag or a digest. It should contain complete qualified image name with tag or digest. For example: marqoai/marqo:abcd1234 or marqoai/marqo@sha256:1234567890abcdef. This is used to pull images from ECR.' | ||
required: true | ||
type: string | ||
mode: | ||
description: 'The mode in which the compatibility tests are to be run. Options: "backwards_compatibility", "rollback"' | ||
options: | ||
- backwards_compatibility | ||
- rollback | ||
required: true | ||
type: choice | ||
|
||
jobs: | ||
Start-Runner: | ||
permissions: | ||
contents: read # This permission is necessary to read repository contents | ||
actions: write # Used by machulav/ec2-github-runner@v2 for managing self-hosted runners. The workflow needs to create and manage GitHub Actions runners on EC2 | ||
id-token: write # Used by aws-actions/configure-aws-credentials@v4. Required for AWS authentication and OIDC token management | ||
checks: write # Used implicitly by GitHub Actions to report job statuses and create check runs | ||
statuses: write # Used implicitly by GitHub Actions to report job statuses and create check runs | ||
name: Start self-hosted EC2 runner | ||
runs-on: ubuntu-latest | ||
outputs: | ||
label: ${{ steps.start-ec2-runner.outputs.label }} | ||
ec2-instance-id: ${{ steps.start-ec2-runner.outputs.ec2-instance-id }} | ||
steps: | ||
- name: Configure AWS credentials | ||
uses: aws-actions/configure-aws-credentials@v1 | ||
with: | ||
aws-access-key-id: ${{ secrets.MARQO_WORKFLOW_TESTS_ACCESS_KEY_ID }} | ||
aws-secret-access-key: ${{ secrets.MARQO_WORKFLOW_TESTS_SECRET_ACCESS_KEY }} | ||
aws-region: us-east-1 | ||
- name: Start EC2 runner | ||
id: start-ec2-runner | ||
uses: machulav/ec2-github-runner@v2 | ||
with: | ||
mode: start | ||
github-token: ${{ secrets.GH_PERSONAL_ACCESS_TOKEN }} | ||
ec2-image-id: ${{ secrets.MARQO_CPU_AMD64_TESTS_INSTANCE_AMI }} | ||
ec2-instance-type: m6i.xlarge | ||
subnet-id: ${{ secrets.MARQO_WORKFLOW_TESTS_SUBNET_ID }} | ||
security-group-id: ${{ secrets.MARQO_WORKFLOW_TESTS_SECURITY_GROUP_ID }} | ||
aws-resource-tags: > # optional, requires additional permissions | ||
[ | ||
{"Key": "Name", "Value": "marqo-compatibility-test-runner-${{ github.run_id }}"}, | ||
{"Key": "GitHubRepo", "Value": "${{ github.repository }}"}, | ||
{"Key": "WorkflowName", "Value": "${{ github.workflow }}"}, | ||
{"Key": "WorkflowRunId", "Value": "${{ github.run_id }}"}, | ||
{"Key": "WorlflowURL", "Value": "${{ github.event.repository.html_url }}/actions/runs/${{ github.run_id }}"}, | ||
{"Key": "PoloRole", "Value": "testing"} | ||
] | ||
compatibility_tests: | ||
# This job runs on the newly created runner | ||
runs-on: ${{ needs.start-runner.outputs.label }} | ||
needs: Start-Runner | ||
steps: | ||
# Step to check out the Marqo repository | ||
- name: checkout marqo repo | ||
uses: actions/checkout@v3 | ||
with: | ||
repository: ${{ github.repository }} #Check out the repository that contains this action since the tests exist in the same repository | ||
fetch-depth: 0 | ||
|
||
# Step to set up Python 3.9 | ||
- name: Set up Python 3.9 | ||
uses: actions/setup-python@v3 | ||
with: | ||
python-version: "3.9" | ||
cache: "pip" | ||
# Step to install dependencies from requirements.txt | ||
- name: Install Dependencies | ||
run: | | ||
pip install -r tests/backwards_compatibility_tests/requirements.txt | ||
# Step to configure AWS credentials | ||
- name: Configure AWS credentials | ||
uses: aws-actions/configure-aws-credentials@v4 | ||
with: | ||
aws-access-key-id: ${{ secrets.ECR_PUSHER_AWS_ACCESS_KEY_ID }} | ||
aws-secret-access-key: ${{ secrets.ECR_PUSHER_AWS_SECRET_ACCESS_KEY }} | ||
aws-region: us-east-1 | ||
|
||
# Step to login to Amazon ECR | ||
- name: Login to Amazon ECR | ||
id: login-ecr | ||
uses: aws-actions/amazon-ecr-login@v2 | ||
|
||
# Step to run the compatibility test. This step can run both backwards_compatibility and rollback tests, based on the MODE argument | ||
- name: Run backwards compatibility test | ||
id: run-backwards-compatibility | ||
env: | ||
FROM_VERSION: ${{ inputs.from_version || github.event.inputs.from_version }} | ||
TO_VERSION: ${{ inputs.to_version || github.event.inputs.to_version }} | ||
TO_IMAGE: ${{ inputs.to_image || github.event.inputs.to_image }} | ||
MODE: ${{ inputs.mode || github.event.inputs.mode }} | ||
run: | | ||
export PYTHONPATH=${{ github.workspace }}:$PYTHONPATH | ||
python tests/backwards_compatibility_tests/compatibility_test_runner.py \ | ||
--mode "$MODE" \ | ||
--from_version "$FROM_VERSION" \ | ||
--to_version "$TO_VERSION" \ | ||
--to_image "$TO_IMAGE" \ | ||
Stop-Runner: | ||
name: Stop self-hosted EC2 runner | ||
permissions: | ||
contents: read # This permission is necessary to read repository contents | ||
actions: write # Used by machulav/ec2-github-runner@v2 for managing self-hosted runners. The workflow needs to create and manage GitHub Actions runners on EC2 | ||
id-token: write # Used by aws-actions/configure-aws-credentials@v4. Required for AWS authentication and OIDC token management | ||
checks: write # Used implicitly by GitHub Actions to report job statuses and create check runs | ||
statuses: write # Used implicitly by GitHub Actions to report job statuses and create check runs | ||
needs: | ||
- Start-Runner # required to get output from the start-runner job | ||
- compatibility_tests # required to wait when the main job is done | ||
runs-on: ubuntu-latest | ||
if: ${{ always() }} # required to stop the runner even if the error happened in the previous jobs | ||
steps: | ||
- name: Configure AWS credentials | ||
uses: aws-actions/configure-aws-credentials@v1 | ||
with: | ||
aws-access-key-id: ${{ secrets.MARQO_WORKFLOW_TESTS_ACCESS_KEY_ID }} | ||
aws-secret-access-key: ${{ secrets.MARQO_WORKFLOW_TESTS_SECRET_ACCESS_KEY }} | ||
aws-region: us-east-1 | ||
- name: Stop EC2 runner | ||
uses: machulav/ec2-github-runner@v2 | ||
with: | ||
mode: stop | ||
github-token: ${{ secrets.GH_PERSONAL_ACCESS_TOKEN }} | ||
label: ${{ needs.start-runner.outputs.label }} | ||
ec2-instance-id: ${{ needs.start-runner.outputs.ec2-instance-id }} |
189 changes: 189 additions & 0 deletions
189
.github/workflows/backwards_compatibility_marqo_orchestrator.yml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,189 @@ | ||
# Orchestrator workflow | ||
name: Marqo Compatibility Tests Orchestrator | ||
|
||
on: | ||
push: | ||
branches: | ||
- mainline | ||
- releases/* | ||
paths-ignore: | ||
- '**.md' | ||
workflow_dispatch: | ||
inputs: | ||
to_version: | ||
description: 'Target Marqo version' | ||
required: true | ||
max_versions_to_test: | ||
description: 'Max versions to test' | ||
required: false | ||
#TODO: Add input for specifying py_marqo branch (https://github.com/marqo-ai/marqo/pull/1024#discussion_r1841556872) | ||
|
||
# Setting MAX_VERSIONS_TO_TEST, this can be a configurable value or if no input is provided, it can be a default value. | ||
env: | ||
MAX_VERSIONS_TO_TEST: ${{ github.event.inputs.max_versions_to_test || 5 }} | ||
|
||
jobs: | ||
check-if-image-exists: | ||
# Responsible for deciding if we should invoke build_push_img.yml GitHub actions workflow in the same repo. | ||
# We do not want to build and push the image if it already exists in the ECR registry, which will be the case if this is a manual developer initiated re-run using the same commit. | ||
name: Check if image already exists in ECR | ||
runs-on: ubuntu-latest | ||
environment: marqo-test-suite | ||
outputs: | ||
image_exists: ${{ steps.check-image.outputs.image_exists }} | ||
image_identifier: ${{ steps.check-image.outputs.image_identifier }} | ||
steps: | ||
- name: Checkout marqo repo | ||
uses: actions/checkout@v3 | ||
with: | ||
fetch-depth: 0 | ||
|
||
- name: Configure AWS credentials | ||
uses: aws-actions/configure-aws-credentials@v4 | ||
with: | ||
aws-access-key-id: ${{ secrets.ECR_PUSHER_AWS_ACCESS_KEY_ID }} | ||
aws-secret-access-key: ${{ secrets.ECR_PUSHER_AWS_SECRET_ACCESS_KEY }} | ||
aws-region: us-east-1 | ||
|
||
# step to check for image existence - it uses aws cli to check if the image exists in the ECR registry "marqo-compatibility-tests" | ||
- name: Check image existence and get identifier | ||
id: check-image | ||
run: | | ||
echo "Checking for image existence" | ||
if IMAGE_DETAILS=$(aws ecr describe-images --repository-name marqo-compatibility-tests --image-ids imageTag=${{ github.sha }} 2>/dev/null); then | ||
echo "image_exists=true" >> $GITHUB_OUTPUT | ||
echo "Image already exists in ECR, will not build and push again. Will be using the image digest from existing image" | ||
IMAGE_IDENTIFIER=$(echo "$IMAGE_DETAILS" | jq -r '.imageDetails[0].imageDigest') | ||
REGISTRY_ID="424082663841.dkr.ecr.us-east-1.amazonaws.com" | ||
FULL_IDENTIFIER="${REGISTRY_ID}/marqo-compatibility-tests@${IMAGE_IDENTIFIER}" | ||
echo "image_identifier=${FULL_IDENTIFIER}" >> $GITHUB_OUTPUT | ||
else | ||
echo "image_exists=false" >> $GITHUB_OUTPUT | ||
echo "Image doesn't exist" | ||
fi | ||
build-and-push-image: | ||
# Job to actually build and push image to ECR registry. This job is only triggered if the image does not already exist in the ECR registry. | ||
name: Build and Push Image | ||
needs: check-if-image-exists | ||
if: needs.check-if-image-exists.outputs.image_exists == 'false' | ||
uses: ./.github/workflows/build_push_img.yml | ||
secrets: inherit | ||
with: | ||
marqo_ref: "${{ github.sha }}" | ||
push_to: "ECR" | ||
image_repo: "marqo-compatibility-tests" | ||
image_tag: "${{ github.sha }}" | ||
|
||
|
||
orchestrate: | ||
# Job to orchestrate backwards compatibility test execution. Majorly responsible for determining to_version and for generating the list of from_version(s) to test against. | ||
name: Orchestrate backwards compatibility test execution | ||
runs-on: ubuntu-latest | ||
needs: [check-if-image-exists, build-and-push-image] | ||
if: always () && (needs.check-if-image-exists.result == 'success') | ||
outputs: | ||
list: ${{ steps.generate-versions.outputs.list }} | ||
to_version: ${{ steps.get-to-version.outputs.to_version }} | ||
environment: marqo-test-suite | ||
steps: | ||
# Step to check out the Marqo repository | ||
- name: Checkout marqo repo | ||
uses: actions/checkout@v3 | ||
with: | ||
fetch-depth: 0 | ||
|
||
# Step to set up Python 3.9 | ||
- name: Set up Python 3.9 | ||
uses: actions/setup-python@v3 | ||
with: | ||
python-version: '3.9' | ||
cache: "pip" | ||
|
||
# Step to install the semver package | ||
- name: Install semver | ||
run: | | ||
pip install semver | ||
# Step to determine the target version | ||
- name: Determine to_version | ||
id: get-to-version | ||
run: | | ||
if [ "${{ github.event_name }}" == "workflow_dispatch" ] && [ -n "${{ github.event.inputs.to_version }}" ]; then | ||
VERSION="${{ github.event.inputs.to_version }}" | ||
else | ||
VERSION=$(python tests/backwards_compatibility_tests/scripts/determine_to_version.py ${{ github.sha }}) | ||
fi | ||
echo "to_version=${VERSION}" >> $GITHUB_OUTPUT | ||
# Step to generate the list of versions to test | ||
- name: Generate version list #this code block just generates the from_version list and stores it in a versions variable as a list | ||
id: generate-versions | ||
run: | | ||
# Run the Python script and capture its output | ||
VERSION_LIST=$(python tests/backwards_compatibility_tests/scripts/generate_versions.py ${{ steps.get-to-version.outputs.to_version }} ${{ env.MAX_VERSIONS_TO_TEST }}) | ||
echo "list=${VERSION_LIST}" >> $GITHUB_OUTPUT | ||
# Step to display the versions to test | ||
- name: display versions | ||
run: | | ||
echo "Versions to test: ${{ steps.generate-versions.outputs.list }} against to_version: ${{ steps.get-to-version.outputs.to_version }}" | ||
- name: Configure AWS credentials | ||
uses: aws-actions/configure-aws-credentials@v4 | ||
with: | ||
aws-access-key-id: ${{ secrets.ECR_PUSHER_AWS_ACCESS_KEY_ID }} | ||
aws-secret-access-key: ${{ secrets.ECR_PUSHER_AWS_SECRET_ACCESS_KEY }} | ||
aws-region: us-east-1 | ||
|
||
run-backwards-compatibility-execution-workflow: | ||
# Job to trigger execution workflows for backwards compatibility test for each version combination | ||
name: Run all backwards compatibility tests execution workflows | ||
needs: [orchestrate, check-if-image-exists, build-and-push-image] | ||
if: always() && (needs.orchestrate.result == 'success') | ||
strategy: | ||
matrix: | ||
from_version: ${{ fromJson(needs.orchestrate.outputs.list) }} | ||
uses: ./.github/workflows/backwards_compatibility_marqo_execution.yml | ||
secrets: inherit | ||
permissions: | ||
contents: read # This permission is necessary to read repository contents | ||
actions: write # Used by machulav/ec2-github-runner@v2 for managing self-hosted runners. The workflow needs to create and manage GitHub Actions runners on EC2 | ||
id-token: write # Used by aws-actions/configure-aws-credentials@v4. Required for AWS authentication and OIDC token management | ||
checks: write # Used implicitly by GitHub Actions to report job statuses and create check runs | ||
statuses: write # Used implicitly by GitHub Actions to report job statuses and create check runs | ||
with: | ||
from_version: ${{ matrix.from_version }} | ||
to_version: ${{ needs.orchestrate.outputs.to_version }} | ||
# Pass the image_identifier to the execution workflow. By image_identifier, we refer to the | ||
# complete qualified image name with the image digest (i.e 424082663841.dkr.ecr.us-east-1.amazonaws.com/marqo-compatibility-tests@sha256:1234567890abcdef). | ||
# The image_identifier can either come from the check-if-image-exists (i.e in case the image already exists in ECR) job or the build-and-push-image (i.e in case the image was built and pushed to ECR) job. | ||
to_image: ${{ needs.check-if-image-exists.outputs.image_exists == 'true' && needs.check-if-image-exists.outputs.image_identifier | ||
|| needs.build-and-push-image.outputs.image_identifier }} | ||
mode: "backwards_compatibility" | ||
|
||
|
||
run-rollback-tests-execution-workflow: | ||
# Job to trigger execution workflows for rollback test for each version combination | ||
name: Run all rollback tests execution workflows | ||
needs: [ orchestrate, check-if-image-exists, build-and-push-image ] | ||
if: always() && (needs.orchestrate.result == 'success') | ||
strategy: | ||
matrix: | ||
from_version: ${{ fromJson(needs.orchestrate.outputs.list) }} | ||
uses: ./.github/workflows/backwards_compatibility_marqo_execution.yml | ||
secrets: inherit | ||
permissions: | ||
contents: read # This permission is necessary to read repository contents | ||
actions: write # Used by machulav/ec2-github-runner@v2 for managing self-hosted runners. The workflow needs to create and manage GitHub Actions runners on EC2 | ||
id-token: write # Used by aws-actions/configure-aws-credentials@v4. Required for AWS authentication and OIDC token management | ||
checks: write # Used implicitly by GitHub Actions to report job statuses and create check runs | ||
statuses: write # Used implicitly by GitHub Actions to report job statuses and create check runs | ||
with: | ||
from_version: ${{ matrix.from_version }} | ||
to_version: ${{ needs.orchestrate.outputs.to_version }} | ||
# Pass the image_identifier to the execution workflow. By image_identifier, we refer to the | ||
# complete qualified image name with the image digest (i.e 424082663841.dkr.ecr.us-east-1.amazonaws.com/marqo-compatibility-tests@sha256:1234567890abcdef). | ||
# The image_identifier can either come from the check-if-image-exists (i.e in case the image already exists in ECR) job or the build-and-push-image (i.e in case the image was built and pushed to ECR) job. | ||
to_image: ${{ needs.check-if-image-exists.outputs.image_exists == 'true' && needs.check-if-image-exists.outputs.image_identifier | ||
|| needs.build-and-push-image.outputs.image_identifier }} | ||
mode: "rollback" |
Oops, something went wrong.