Hiding the model internal data when retrieving index settings if the model is a Marqtune model. #1018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keshav
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
keshav
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
keshav
had a problem deploying
to
marqo-test-suite
GitHub Actions
Error
keshav
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
papa99do
reviewed
Oct 22, 2024
papa99do
reviewed
Oct 22, 2024
papa99do
reviewed
Oct 22, 2024
papa99do
reviewed
Oct 22, 2024
keshav
had a problem deploying
to
marqo-test-suite
GitHub Actions
Error
keshav
had a problem deploying
to
marqo-test-suite
GitHub Actions
Error
keshav
had a problem deploying
to
marqo-test-suite
GitHub Actions
Error
keshav
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
keshav
had a problem deploying
to
marqo-test-suite
GitHub Actions
Failure
keshav
had a problem deploying
to
marqo-test-suite
GitHub Actions
Failure
keshav
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
keshav
had a problem deploying
to
marqo-test-suite
GitHub Actions
Error
keshav
had a problem deploying
to
marqo-test-suite
GitHub Actions
Error
keshav
had a problem deploying
to
marqo-test-suite
GitHub Actions
Failure
keshav
had a problem deploying
to
marqo-test-suite
GitHub Actions
Error
keshav
had a problem deploying
to
marqo-test-suite
GitHub Actions
Error
keshav
had a problem deploying
to
marqo-test-suite
GitHub Actions
Error
keshav
had a problem deploying
to
marqo-test-suite
GitHub Actions
Error
keshav
had a problem deploying
to
marqo-test-suite
GitHub Actions
Error
keshav
had a problem deploying
to
marqo-test-suite
GitHub Actions
Error
keshav
had a problem deploying
to
marqo-test-suite
GitHub Actions
Error
keshav
had a problem deploying
to
marqo-test-suite
GitHub Actions
Error
keshav
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
keshav
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
keshav
had a problem deploying
to
marqo-test-suite
GitHub Actions
Error
keshav
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
keshav
had a problem deploying
to
marqo-test-suite
GitHub Actions
Error
keshav
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
keshav
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
farshidz
approved these changes
Nov 1, 2024
farshidz
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
farshidz
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
farshidz
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
keshav
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
keshav
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
keshav
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
keshav
had a problem deploying
to
marqo-test-suite
GitHub Actions
Failure
vicilliar
pushed a commit
that referenced
this pull request
Nov 29, 2024
…model is a Marqtune model. (#1018) Co-authored-by: Jesse Clark <[email protected]> Co-authored-by: TomHamer <[email protected]> Co-authored-by: Farshid Zavareh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
This PR introduces a feature to hide internal model data if a model is flagged as a Marqtune model in the/indexes//settings response. Additionally, it includes tests to verify that the model's internal data is appropriately blocked for Marqtune models.
What is the current behavior? (You can also link to an open issue here)
Currently, the model properties in index settings include internal model data, such as the model's name, dimensions, and model location, even if the model is a Marqtune model. This could expose internal model details that should remain within Marqo ecosystem.
What is the new behavior (if this is a feature change)?
With this change, if a model is marked as a Marqtune model using the "isMarqtuneModel" property, the index settings API will block internal model data, returning only the "isMarqtuneModel": True property in the response. This aligns with internal implementation of Marqtune models.
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No, this PR does not introduce a breaking change. Users can continue to access model properties as usual, with the exception that Marqtune model data is intentionally removed.
Other information:
Related Python client changes (link commit/PR here)
NA
Related documentation changes (link commit/PR here)
There is no documentation on this feature yet.
Please check if the PR fulfills these requirements