OverlappingEdgeCheck Pedestrian Area Definition (osmlab#638)

* bug fix: osmlab#637 * spotless
martapako · Dec 8, 2021 · e7416af · e7416af
1 parent 63523b1
commit e7416af
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/...ain/java/org/openstreetmap/atlas/checks/validation/linear/edges/OverlappingEdgeCheck.java b/...ain/java/org/openstreetmap/atlas/checks/validation/linear/edges/OverlappingEdgeCheck.java
@@ -128,6 +128,7 @@ protected List<String> getFallbackInstructions()
     private boolean edgeIsArea(final Edge edge)
     {
         return (Validators.isOfType(edge, HighwayTag.class, HighwayTag.PEDESTRIAN)
+                || Validators.isOfType(edge, HighwayTag.class, HighwayTag.FOOTWAY)
                 || Validators.isOfType(edge, ManMadeTag.class, ManMadeTag.PIER))
                 && (AREA_YES_TAG.test(edge) || CommonMethods.isClosedWay(edge))
                 || (Validators.isOfType(edge, HighwayTag.class, HighwayTag.SERVICE)

diff --git a/.../org/openstreetmap/atlas/checks/validation/linear/edges/OverlappingEdgeCheckTestRule.java b/.../org/openstreetmap/atlas/checks/validation/linear/edges/OverlappingEdgeCheckTestRule.java
@@ -124,13 +124,15 @@ public class OverlappingEdgeCheckTestRule extends CoreTestRule
     private Atlas pedestrianAreaOverlapPedestrianAreaClosedWayAtlas;
 
     @TestAtlas(nodes = { @Node(coordinates = @Loc(value = ONE)),
-            @Node(coordinates = @Loc(value = TWO)),
-            @Node(coordinates = @Loc(value = THREE)) }, edges = {
+            @Node(coordinates = @Loc(value = TWO)), @Node(coordinates = @Loc(value = THREE)),
+            @Node(coordinates = @Loc(value = FOUR)), }, edges = {
                     @Edge(id = "521118537000000", coordinates = { @Loc(value = ONE),
                             @Loc(value = TWO), @Loc(value = THREE), @Loc(value = FOUR),
-                            @Loc(value = ONE) }, tags = { "highway=pedestrian" }),
+                            @Loc(value = ONE) }, tags = { "highway=pedestrian", "area=yes" }),
                     @Edge(id = "521118538000000", coordinates = { @Loc(value = TWO),
-                            @Loc(value = THREE) }, tags = { "highway=pedestrian" }) })
+                            @Loc(value = THREE) }, tags = { "highway=pedestrian" }),
+                    @Edge(id = "521118539000000", coordinates = { @Loc(value = FOUR),
+                            @Loc(value = ONE) }, tags = { "highway=footway" }) })
     private Atlas pedestrianAreaOverlapPedestrianEdgeAtlas;
 
     @TestAtlas(nodes = { @Node(coordinates = @Loc(value = ONE)),