Merge pull request #194 from martincollignon/fix/water-projects-valid…

…ation-order fix: Reorder geometry operations to maintain validity
martincollignon · Dec 14, 2024 · dc80893 · dc80893
2 parents 1b72dfc + 38d49ba
commit dc80893
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/backend/src/sources/parsers/water_projects.py b/backend/src/sources/parsers/water_projects.py
@@ -285,14 +285,14 @@ async def write_to_storage(self, features, dataset):
                         cleaned = dissolved.buffer(0)
                         dissolved_gdf = gpd.GeoDataFrame(geometry=[cleaned], crs="EPSG:25832")
 
-                    # Convert to 4326 for storage
-                    logger.info("Converting to WGS84 for storage...")
-                    dissolved_gdf = dissolved_gdf.to_crs("EPSG:4326")
-
-                    # Validate final geometries before saving
+                    # Validate while still in 25832
                     logger.info("Validating final dissolved geometries...")
                     dissolved_gdf = validate_and_transform_geometries(dissolved_gdf, f"{dataset}_dissolved")
 
+                    # Then convert to 4326 for storage
+                    logger.info("Converting to WGS84 for storage...")
+                    dissolved_gdf = dissolved_gdf.to_crs("EPSG:4326")
+
                     # Write dissolved version
                     temp_dissolved = f"/tmp/{dataset}_dissolved.parquet"
                     dissolved_gdf.to_parquet(temp_dissolved)