Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* 테스트 케이스: - 로그아웃 요청 - 성공 응답 - 로그아웃 요청 - 실패 응답 - 액세스 토큰 재발급 - 성공 응답
swinb
approved these changes
Sep 19, 2023
Comment on lines
+44
to
+51
| protected Jwt 로그인을_한다(MemberFixture memberFixture) { | ||
| String providerName = memberFixture.getoAuthAttributes().providerName; | ||
| OAuthProfile oAuthProfile = memberFixture.toOauthProfile(); | ||
|
|
||
| Long memberId = memberService.oAuthLogin(providerName, oAuthProfile); | ||
|
|
||
| return jwtService.issueJwt(memberId); | ||
| } |
There was a problem hiding this comment.
MemberFixture은 빈이 아니라 로그인 기능을 테스트에 적용하기 위한 파라미터같고
클래스 자체가 테스트 유틸 느낌인가요??
swinb
pushed a commit
that referenced
this pull request
Sep 22, 2023
* test: 인수 테스트를 위한 부모 클래스 구현 * chore: build.gradle에 RestAssured 의존성 추가 * test: 인증/인가 관련 테스트 코드 작성 * 테스트 케이스: - 로그아웃 요청 - 성공 응답 - 로그아웃 요청 - 실패 응답 - 액세스 토큰 재발급 - 성공 응답
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔑 Key changes
👋 To reviewers
테스트 코드 작성을 하려면 어쩔 수 없이 dto들의 생성자가 필요하여 생성자를 추가하였습니다.
✔️ Completed Issue Number
close #129