Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swinb
approved these changes
Oct 4, 2023
Comment on lines
21
to
22
| Member member = memberService.getMemberReferenceById(memberId); // 없는 경우에 무슨 예외 터지는지 확인 | ||
| Product product = productService.findById(productId); |
|
|
||
| private final Long senderId; | ||
| private final String content; | ||
| private final Instant sentTime; |
There was a problem hiding this comment.
저번에 구두로 설명드렸었는데, 간단히 설명드리자면
LocalDate, LocalTime, LocalDateTime은 타임존에 얽매이지 않는 문제가 있고 Date 클래스는 다양한 문제점이 있어 deprecated되었습니다. (왜 deprecated 되었는지는 따로 찾아보면 좋을 것 같아요!)
그래서 자바 1.8부터 제공한 Instant를 사용하게 되었습니다.
이전 코드도 수정하고 싶었는데, 시간이 없어서 기존 코드는 수정하지 못하고 새로 추가된 코드만 우선 Instant로 했습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔑 Key changes
👋 To reviewers
아직 안읽은 메시지 개수 카운팅 하는 로직을 구현하지 못했습니다.
✔️ Completed Issue Number
close #127