Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

finish museum_2 #438

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

finish museum_2 #438

wants to merge 5 commits into from

Conversation

Oleksii-Bidiak
Copy link

vadiimvooo
vadiimvooo suggested changes May 17, 2024
View reviewed changes
Copy link

@vadiimvooo vadiimvooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job. A few changes required:

  1. Header should be fixed:
    image
  2. Header should be fixed in menu page
    image
  3. Margins for this block should be fixed according to mockup
    image

@Oleksii-Bidiak Oleksii-Bidiak requested a review from vadiimvooo May 17, 2024 18:48
l4st1m0za
l4st1m0za suggested changes May 18, 2024
View reviewed changes
Copy link

@l4st1m0za l4st1m0za left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the header. If you have any questions feel free to ask in the chat

@Oleksii-Bidiak Oleksii-Bidiak requested a review from l4st1m0za May 18, 2024 08:10
nazarmatsevych
nazarmatsevych approved these changes May 18, 2024
View reviewed changes
Copy link

@nazarmatsevych nazarmatsevych left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!

This link should also open a google map address in a new tab
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nazarmatsevych nazarmatsevych nazarmatsevych approved these changes

@vadiimvooo vadiimvooo Awaiting requested review from vadiimvooo

@l4st1m0za l4st1m0za Awaiting requested review from l4st1m0za

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Oleksii-Bidiak @l4st1m0za @nazarmatsevych @vadiimvooo