Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #621

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Solution #621

wants to merge 1 commit into from

Conversation

SerhiiVoitiuk
Copy link

No description provided.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on implementing the getHumanAge function! 🎉 The code meets the task requirements and constraints, and the test cases are well-structured. Just a small note: consider adjusting the test case on line 15 to use input values less than 14, such as getHumanAge(13, 13), to align perfectly with the task description. Keep up the excellent work! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

Comment on lines +15 to +17
test('should return [0, 0] if CatAge and DogAge < 14', () => {
expect(getHumanAge(14, 14)).toEqual([0, 0]);
});

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test case description states that it should return [0, 0] if CatAge and DogAge are less than 14. However, the input values are exactly 14. Consider changing the input values to something less than 14, such as getHumanAge(13, 13), to match the test description and the task requirements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants