Added classes: Lottery Ball Colors and ColorSupplier #1750
Conversation
There was a problem hiding this comment.
Great job on implementing the task requirements! 🎉 Your code meets all the core requirements, and the functionality is intact. While there are minor suggestions for improvement, such as using name() instead of toString() for enum constants and employing a loop for creating multiple Ball objects, these do not impact the overall functionality. Keep up the good work, and consider these suggestions for cleaner and more maintainable code in the future! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| Ball ball1 = lottery.getRandomBall(); | ||
| Ball ball2 = lottery.getRandomBall(); | ||
| Ball ball3 = lottery.getRandomBall(); |
There was a problem hiding this comment.
Consider using a loop to create multiple Ball objects instead of creating each one individually. This aligns with the checklist recommendation to use a loop for creating several objects of the same class. For example, you could use a for loop to create and store the balls in an array.
| return null; | ||
| Random random = new Random(); | ||
| int index = random.nextInt(colors.length); | ||
| return colors[index].toString(); |
There was a problem hiding this comment.
Consider using colors[index].name() instead of colors[index].toString() to get the string representation of the enum constant. According to the checklist, using name() is preferred because toString() can be overridden, which might lead to unexpected results.
No description provided.