Lottery #1764
Open
Lottery #1764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… generated with random colors and numbers, and the result is printed to the screen.
… generated with random colors and numbers, and the result is printed to the screen.
mateacademy-ai-mentor
approved these changes
Feb 6, 2025
There was a problem hiding this comment.
Great job on implementing the solution! 🎉 The code meets the task requirements and constraints effectively. While the inheritance in the Application class is unnecessary, it doesn't impact the core functionality. Consider removing it for cleaner design. Keep up the good work! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| @@ -1,7 +1,12 @@ | |||
| package core.basesyntax; | |||
|
|
|||
| public class Application { | |||
| public class Application extends Lottery { | |||
There was a problem hiding this comment.
The Application class should not extend Lottery. The task does not require inheritance here, and extending Lottery is unnecessary for the functionality of generating random balls. Remove the inheritance to align with the task requirements.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.