pow method finished in CustomMathPow class #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boroda4436
suggested changes
Aug 20, 2019
| */ | ||
| public int pow(int number, int exponential) { | ||
| return 0; | ||
| double result = 1; |
There was a problem hiding this comment.
@NikolayKatsai why you are using double here?
boroda4436
suggested changes
Aug 20, 2019
| for (int i = 0; i < exponential; i++) { | ||
| result *= number; | ||
| if (result < 0) { | ||
| return 2147483647; |
There was a problem hiding this comment.
@NikolayKatsai why are you returning this number?
There was a problem hiding this comment.
2147483647 максимальне значення інта, а в тестах приходять данні які переповнюють інт, і як відповідь тест очікує саме максимальне значення інта, тому його і повертаю))
There was a problem hiding this comment.
Це не корректна поведінка. Якщо є помилка в тестах - то необхідно виправити тест, а не підганяти імплементацію. Це порада на майбутнє
boroda4436
approved these changes
Aug 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.