Your commit message #495
Closed
Your commit message #495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danon321
reviewed
Nov 29, 2023
| </header> | ||
| <section class="home" id="home"> | ||
| <h3 class="home__text">We bake your fantasies — croissants, cakes, cookies, and cupcakes.</h3> | ||
| <h1 class="home__title">Creative bakery</h1> |
There was a problem hiding this comment.
Widza ze masz wiecej niz jedno h1 na stronie. Raczej powinno sie trzymac zasady ze h1 jest tylko jedno
danon321
reviewed
Nov 29, 2023
| </section> | ||
| <section class="aboutUs" id="aboutUs"> | ||
| <div class="aboutUs__description"> | ||
| <h1 class="aboutUs__description-title">Few words About us</h1> |
There was a problem hiding this comment.
ten tytuł i "What we bake" wygladaja tak samo. Powinienes to zrobic specjalna klasa tylko dołączoną do sekcji. czyli np section__title.
danon321
reviewed
Nov 29, 2023
|
|
||
| // position: fixed; | ||
| // background-color: $c-lightBlue; | ||
| // z-index: 100; |
danon321
reviewed
Nov 29, 2023
| @import "home.scss"; | ||
| @import "products.scss"; | ||
| @import "aboutUs.scss"; | ||
| @import "footer.scss"; |
There was a problem hiding this comment.
wydaje mi sie ze ".scss" jest zbędne w zapisie tutaj
|
Błedy w testach |
|
. |
danon321
approved these changes
Dec 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEMO LINK