Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Develop #505

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Develop #505

wants to merge 8 commits into from

Conversation

Mariana-VV
Copy link

@Mariana-VV Mariana-VV commented Dec 2, 2023 •
edited
Loading

https:Mariana-VV.github.io/layout_creativeBakery/

l4st1m0za
l4st1m0za suggested changes Dec 3, 2023
View reviewed changes
Copy link

@l4st1m0za l4st1m0za left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Decent job done here! See the reqiered changes:

  1. Your menu header is now alighned properly. When menu is opened, it should be on the same level as the header of the page, and your menu-header as higher
Screenshot 2023-12-03 at 13 15 00 Screenshot 2023-12-03 at 13 15 09

@Mariana-VV Mariana-VV requested a review from l4st1m0za December 3, 2023 13:18
@Mariana-VV
Copy link
Author

Decent job done here! See the reqiered changes:

  1. Your menu header is now alighned properly. When menu is opened, it should be on the same level as the header of the page, and your menu-header as higher

Screenshot 2023-12-03 at 13 15 00 Screenshot 2023-12-03 at 13 15 09

@Mariana-VV Mariana-VV closed this Dec 3, 2023
@Mariana-VV Mariana-VV reopened this Dec 3, 2023
volodymyr-soltys97
volodymyr-soltys97 suggested changes Dec 3, 2023
View reviewed changes
Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 👍
Let's improve your code

  1. Add a transition for hover effects everywhere
image image
  1. Need to fix the indents between these elements as on the design
image image

anastasiia-tilikina
anastasiia-tilikina suggested changes Dec 4, 2023
View reviewed changes
Copy link

@anastasiia-tilikina anastasiia-tilikina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're close!)

pls watch the video and make final improvements.

VitaliyBondarenko1982
VitaliyBondarenko1982 approved these changes Dec 16, 2023
View reviewed changes
Copy link

@VitaliyBondarenko1982 VitaliyBondarenko1982 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VitaliyBondarenko1982 VitaliyBondarenko1982 VitaliyBondarenko1982 approved these changes

@l4st1m0za l4st1m0za Awaiting requested review from l4st1m0za

@volodymyr-soltys97 volodymyr-soltys97 Awaiting requested review from volodymyr-soltys97

@anastasiia-tilikina anastasiia-tilikina Awaiting requested review from anastasiia-tilikina

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Mariana-VV @VitaliyBondarenko1982 @volodymyr-soltys97 @l4st1m0za @anastasiia-tilikina