Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Develop #514

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Develop #514

wants to merge 5 commits into from

Conversation

Reaffith
Copy link

Viktor-Kost
Viktor-Kost suggested changes Dec 25, 2023
View reviewed changes
Copy link

@Viktor-Kost Viktor-Kost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

To improve:

  1. external links (such as social networks, map etc) should open in a new tab
  2. buttons "order" should lead to the contact in footer
  3. the “learn more” button should lead to the “About us” block
  4. blog link in the footer lead to one of section, but the same link in the header does not
  5. add desktop max-width to a header section the same as you did with other section
  6. remove body scroll when menu is opened
  7. logos overlap each other
Screenshot 2023-12-25 at 20 54 55

@Reaffith Reaffith requested a review from Viktor-Kost December 25, 2023 19:18
etojeDenys
etojeDenys suggested changes Dec 26, 2023
View reviewed changes
Copy link

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only one comment:
disable the scroll when menu is open
image

@Reaffith Reaffith requested a review from etojeDenys December 26, 2023 19:38
l4st1m0za
l4st1m0za suggested changes Dec 26, 2023
View reviewed changes
Copy link

@l4st1m0za l4st1m0za left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Remove link styles here
image

@Reaffith Reaffith requested a review from l4st1m0za December 26, 2023 19:59
etojeDenys
etojeDenys approved these changes Dec 27, 2023
View reviewed changes
Copy link

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etojeDenys etojeDenys etojeDenys approved these changes

@Viktor-Kost Viktor-Kost Awaiting requested review from Viktor-Kost

@l4st1m0za l4st1m0za Awaiting requested review from l4st1m0za

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Reaffith @l4st1m0za @etojeDenys @Viktor-Kost