Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

results #615

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

results #615

wants to merge 6 commits into from

Conversation

maxmodrr
Copy link

@maxmodrr maxmodrr commented Sep 28, 2024 •
edited
Loading

volodymyr-soltys97
volodymyr-soltys97 suggested changes Sep 28, 2024
View reviewed changes
Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, your demo link isn't working, you need to make a deploy and check it after on the demo
image

README.md
@@ -22,7 +22,7 @@ Implement landing page according to [Figma design](https://www.figma.com/file/dY
11. `git push origin develop` - to send you code for PR.
12. Create a Pull Request (PR) from your branch `develop` to branch `master` of original repo.
13. Replace `<your_account>` with your Github username in the
[DEMO LINK](https://<your_account>.github.io/layout_creativeBakery/).
[DEMO LINK](https://maxmodrr.github.io/layout_creativeBakery/).
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add this link to the PR description
image

anastasiiavorobiova
anastasiiavorobiova suggested changes Sep 29, 2024
View reviewed changes
Copy link

@anastasiiavorobiova anastasiiavorobiova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!
Screenshot 2024-09-29 at 12 28 44
Consider adding a favicon
Screenshot 2024-09-29 at 12 28 03
Check the distance here
Screenshot 2024-09-29 at 12 26 13
Consider using a mailto link
Screenshot 2024-09-29 at 12 25 46
Screenshot 2024-09-29 at 12 25 58
Consider adding hover styles here

volodymyr-soltys97
volodymyr-soltys97 suggested changes Sep 30, 2024
View reviewed changes
Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 👍
Let's improve your page

  1. Add hover effects for all clickable elements on the page
image
  1. Need to open additional links in the new tab
image
  1. Add transition when this menu appears on the page and remove scroll when menu is open
image

anastasiiavorobiova
anastasiiavorobiova approved these changes Oct 8, 2024
View reviewed changes
Copy link

@anastasiiavorobiova anastasiiavorobiova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anastasiiavorobiova anastasiiavorobiova anastasiiavorobiova approved these changes

@volodymyr-soltys97 volodymyr-soltys97 Awaiting requested review from volodymyr-soltys97

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maxmodrr @volodymyr-soltys97 @anastasiiavorobiova