Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add task solution #1019

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

add task solution #1019

wants to merge 2 commits into from

Conversation

Uandrik
Copy link

@Uandrik Uandrik commented Dec 10, 2024

@Uandrik
Copy link
Author

Uandrik commented Dec 10, 2024

Why there is an error 404 here?

Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, you need to run command npm run deploy in terminal, if you need some help feel free in the fe_chat
image

@TarasHoliuk
Copy link

  1. Fix layout in this section:

image
image

  1. There should be some margin (check figma) between the title and subtitle:

image

  1. Add hover effect to links and nav links (in the header as well):

image

  1. Make blue buttons 100% width on the mobile version. No need to hardcode width - in the figma we see an example of mobile version design on 320px. But it should look the same on let's say 400px too (i.e. should be full-width):

image

Also, add a hover effect to such buttons.

  1. Add placeholders:

image

  1. I know there is no design for a mobile menu, so it's a suggestion. But it'll look better if you decrease the font size for links (make it the same as in the footer) add the logo at the top (same as in the header) and close "X" button in the top right angle

Copy link

@TarasHoliuk TarasHoliuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GJ 👍
Check comments

@Uandrik
Copy link
Author

Uandrik commented Dec 12, 2024

https://snipboard.io/0WCP5a.jpg I don't see a problem with placeholders.

Sorry, now I see, but I don't know why.

@Uandrik Uandrik requested a review from TarasHoliuk December 12, 2024 17:50
Copy link

@VitaliyBondarenko1982 VitaliyBondarenko1982 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants