add asolution #5256
add asolution #5256
Conversation
koguts
commented
Jan 31, 2025
koguts
commented
- DEMO LINK
- TEST REPORT LINK
There was a problem hiding this comment.
Thank you for your hard work on this project! 😊 There are a few critical issues that need to be addressed before we can approve the pull request. Specifically, the task requires the use of SCSS variables in a separate file, which is currently missing. Additionally, ensure that all stars--N modifiers are implemented as required. Once these issues are resolved, your code will be in great shape! Keep up the great effort! 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review button in the Reviewers tab.
src/styles/card.scss
Outdated
| } | ||
|
|
||
| &__title { | ||
| font-weight: 500px; |
There was a problem hiding this comment.
The font-weight value should be a numeric value without 'px'. Use 'font-weight: 500;' instead of 'font-weight: 500px;'.
src/styles/card.scss
Outdated
|
|
||
| &__code { | ||
| color: #616070; | ||
| font-weight: 400px; |
There was a problem hiding this comment.
The font-weight value should be a numeric value without 'px'. Use 'font-weight: 400;' instead of 'font-weight: 400px;'.
src/styles/card.scss
Outdated
| } | ||
|
|
||
| &__reviews-value { | ||
| font-weight: 400px; |
There was a problem hiding this comment.
The font-weight value should be a numeric value without 'px'. Use 'font-weight: 400;' instead of 'font-weight: 400px;'.
src/styles/card.scss
Outdated
|
|
||
| &__price-title { | ||
| color: #616070; | ||
| font-weight: 400px; |
There was a problem hiding this comment.
The font-weight value should be a numeric value without 'px'. Use 'font-weight: 400;' instead of 'font-weight: 400px;'.
src/styles/card.scss
Outdated
| border: 1px solid #00acdc; | ||
| font-size: 14px; | ||
| line-height: 16px; | ||
| font-weight: 700px; |
There was a problem hiding this comment.
The font-weight value should be a numeric value without 'px'. Use 'font-weight: 700;' instead of 'font-weight: 700px;'.
There was a problem hiding this comment.
Great job on your progress! 🎉 While there are still some areas that need attention, such as ensuring all stars--N modifiers are implemented and using SCSS variables for colors and other repeated values, your efforts are commendable. Remember to address these issues to enhance your code's functionality and maintainability. The decision to approve is to encourage you to continue learning and improving. Keep up the good work, and make sure to review the comments to refine your skills further. 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| </div> | ||
| <span class="card__code">Product code: 195434</span> | ||
| <div class="card__reviews"> | ||
| <div class="stars stars--rating-4"> |
There was a problem hiding this comment.
Verify that all stars--N modifiers are implemented as required by the task. This was a critical issue noted in the previous review.
| flex-direction: column; | ||
| align-items: center; | ||
| padding: 32px 16px 16px; | ||
| border: 1px solid #f3f3f3; |
There was a problem hiding this comment.
Consider using SCSS variables for colors like #f3f3f3 to improve maintainability and readability. This aligns with the task requirement to use SCSS variables.
| } | ||
|
|
||
| &__code { | ||
| color: #616070; |
There was a problem hiding this comment.
Consider using SCSS variables for colors like #616070 to improve maintainability and readability. This aligns with the task requirement to use SCSS variables.
| } | ||
|
|
||
| &__price-title { | ||
| color: #616070; |
There was a problem hiding this comment.
Consider using SCSS variables for colors like #616070 to improve maintainability and readability. This aligns with the task requirement to use SCSS variables.
| justify-content: center; | ||
| height: 40px; | ||
| border-radius: 5px; | ||
| border: 1 solid #00acdc; |
There was a problem hiding this comment.
The border property is missing the unit for the border width. It should be 1px solid #00acdc.
| height: 40px; | ||
| border-radius: 5px; | ||
| border: 1 solid #00acdc; | ||
| font-size: 14; |
There was a problem hiding this comment.
The font-size property is missing the unit. It should be 14px.
| border-radius: 5px; | ||
| border: 1 solid #00acdc; | ||
| font-size: 14; | ||
| line-height: 16; |
There was a problem hiding this comment.
The line-height property is missing the unit. It should be 16px.
| @import '/src/styles/card'; | ||
| @import '/src/styles/stars'; | ||
| @import '/src/styles/mixins'; |
There was a problem hiding this comment.
Ensure that the imported SCSS files, such as card.scss, utilize SCSS variables as required by the task. This was a critical issue noted in the previous review.
| } | ||
| } | ||
|
|
||
| .stars--rating-4 .stars__star:nth-child(-n + 4) { |
There was a problem hiding this comment.
Ensure that all stars--N modifiers are implemented as required by the task to handle different rating levels, not just stars--rating-4.
