Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement task #5259

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

implement task #5259

wants to merge 1 commit into from

Conversation

Karabesk
Copy link

@Karabesk Karabesk commented Feb 1, 2025

  • DEMO LINK

  • TEST REPORT LINK

  • there 2 BEM blocks card and stars each in their own file

  • SCSS Nesting is used for elements, modifiers and pseudo-classes

  • SCSS Variables are used for main values and placed in a separate file

  • all stars--N modifiers work as expected (Highlight first N stars)

  • Code follows all the Code Style Rules ❗️

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on the implementation! 🎉 Your code meets the core requirements, and you've done well with the BEM methodology, SCSS nesting, and variable usage. While there are a few minor issues, such as ensuring all stars--N modifiers are implemented and checking the background-image paths, these do not significantly impact the functionality. Keep up the good work and consider these points for future improvements. 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants