Develop #5274
Open
Develop #5274
+173
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateacademy-ai-mentor
approved these changes
Feb 3, 2025
There was a problem hiding this comment.
Great job on your implementation! 🎉 Your code is well-structured and meets almost all the task requirements. The only thing missing is a separate SCSS variables file, which is a minor issue and doesn't impact the functionality. Keep up the good work, and consider adding that file for even better code organization in the future! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
lucasschumann
force-pushed
the
develop
branch
from
fe3ac2a to
4f12f10
Compare
pedro-ruas
suggested changes
Feb 5, 2025
| </div> | ||
| <div class="card__code">Product code: 195434</div> | ||
| <div class="card__reviews"> | ||
| <div class="stars"> |
There was a problem hiding this comment.
This should use the same styling as in Stars task.
This means, here should also have a modifier for stars--4
| border-radius: 0.5px; | ||
| } | ||
|
|
||
| &__star:nth-child(-n + 4) { |
There was a problem hiding this comment.
Should be applied using a modifier, not as fixed styling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEMO LINK
TEST REPORT LINK