product card

[katarzynamilewska]

• DEMO LINK
• TEST REPORT LINK

[mateacademy-ai-mentor]

Thank you for your hard work on this project! 😊 While your code is mostly on point, there are a few critical issues that need to be addressed before we can proceed. Specifically, SCSS variables should be used and placed in a separate file, and the BEM blocks card and stars need to be separated into individual SCSS files. These changes are essential to meet the core requirements of the task. Once these are resolved, you'll be all set! Keep up the great work, and don't hesitate to reach out if you need any help. 🚀

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review button in the Reviewers tab.

[mateacademy-ai-mentor]

Review Summary

Great job on your submission! 🎉 Your code meets the task requirements and constraints effectively. Here’s a quick summary of what you did well and areas for improvement:

• SCSS Variables: You've correctly used SCSS variables and placed them in a separate file named _variables.scss. This promotes reusability and consistency across your styles.

• BEM Blocks: The separation of BEM blocks into individual SCSS files (card.scss and stars.scss) is well-executed. This modular approach enhances maintainability.

• SCSS Nesting: You've utilized SCSS nesting for elements, modifiers, and pseudo-classes in both card.scss and stars.scss, which is great for readability and organization.

• Attributes and Styles: The required data-qa attributes are present in the HTML file, ensuring that your code meets the task specifications.

• Image Paths: The background-image paths in stars.scss are correctly set relative to index.scss, which is crucial for proper asset loading.

• Font Usage: The required font is imported from Google Fonts, aligning with the task requirements.

While your code is approved, please pay attention to the following critical issue that should be addressed in future projects:

• SCSS File Import: Ensure that the SCSS files are correctly structured and linked, as there was a critical issue with the SCSS file import initially. Proper linking is essential for the functionality of your styles.

This decision is made to help you move forward with your learning. Please review the comments and continue to improve your code. Keep up the great work and learn from any mistakes to enhance your skills further! 🚀

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

[mateacademy-ai-mentor]

The SCSS file index.scss is linked here. Ensure that SCSS variables are used and placed in a separate file, and that the BEM blocks card and stars are separated into individual SCSS files as per the task requirements.