Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #1749

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

EvgeniyChernyakIT
Copy link

No description provided.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on implementing the Car and CarWashStation classes! 🎉 Your code meets the task requirements and constraints effectively. The only minor issue is with the calculation of the new average rating in the rate_service method due to operator precedence. Make sure to enclose the expression (self.average_rating * self.count_of_ratings) + rating in parentheses to ensure the correct calculation. Keep up the good work and happy coding! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

Comment on lines +40 to +43
def rate_service(self, rating: float) -> float:
avg_rating = (self.average_rating * self.count_of_ratings) + rating
self.count_of_ratings += 1
self.average_rating = round(avg_rating / self.count_of_ratings, 1)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an issue with the calculation of the new average rating in the rate_service method. The expression (self.average_rating * self.count_of_ratings) + rating should be enclosed in parentheses to ensure the correct order of operations. Otherwise, the addition of rating might not be calculated as intended due to operator precedence.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants