Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Solution' #1803

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

'Solution' #1803

wants to merge 2 commits into from

Conversation

viktoriaom
Copy link

No description provided.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Great job on implementing the Car and CarWashStation classes with all the required functionalities! 🎉 Your code meets the task requirements and adheres to the style guidelines. Just a small suggestion: in the calculate_washing_price method, consider adding a check to handle cases where distance_from_city_center is zero to prevent any potential division by zero errors. Keep up the good work and happy coding! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

app/main.py Outdated
Comment on lines 31 to 35
def calculate_washing_price(self, car: Car) -> float:
return round((car.comfort_class
* (self.clean_power - car.clean_mark)
* self.average_rating
/ self.distance_from_city_center), 1)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the calculate_washing_price method, there is a potential division by zero error if distance_from_city_center is zero. Consider adding a check to handle this case to avoid runtime errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants