Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #1804

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Solution #1804

wants to merge 1 commit into from

Conversation

viki-kurylo
Copy link

No description provided.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Great job on implementing the Car and CarWashStation classes! 🎉 Your code is well-structured and meets the task requirements. Just a small tweak is needed: update the parameter type for car in the calculate_washing_price method to Car for type correctness. Keep up the excellent work, and happy coding! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

self.average_rating = average_rating
self.count_of_ratings = count_of_ratings

def calculate_washing_price(self, car: type) -> float:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The parameter car in calculate_washing_price should be of type Car instead of type. Update it to car: Car to ensure type correctness.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on implementing the Car and CarWashStation classes! 🎉 Your code meets the task requirements and constraints effectively. While there is a minor issue with type hinting in the calculate_washing_price method, it doesn't critically impact functionality. Keep up the good work, and consider refining the type hint for even better code clarity. Happy coding! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

self.average_rating = average_rating
self.count_of_ratings = count_of_ratings

def calculate_washing_price(self, car: type) -> float:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The parameter car in the calculate_washing_price method should have a type hint of Car instead of type. This ensures that the method expects an instance of the Car class.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants