-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Solution #1804
base: master
Are you sure you want to change the base?
Solution #1804
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job on implementing the Car
and CarWashStation
classes! 🎉 Your code is well-structured and meets the task requirements. Just a small tweak is needed: update the parameter type for car
in the calculate_washing_price
method to Car
for type correctness. Keep up the excellent work, and happy coding! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
self.average_rating = average_rating | ||
self.count_of_ratings = count_of_ratings | ||
|
||
def calculate_washing_price(self, car: type) -> float: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The parameter car
in calculate_washing_price
should be of type Car
instead of type
. Update it to car: Car
to ensure type correctness.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job on implementing the Car
and CarWashStation
classes! 🎉 Your code meets the task requirements and constraints effectively. While there is a minor issue with type hinting in the calculate_washing_price
method, it doesn't critically impact functionality. Keep up the good work, and consider refining the type hint for even better code clarity. Happy coding! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
self.average_rating = average_rating | ||
self.count_of_ratings = count_of_ratings | ||
|
||
def calculate_washing_price(self, car: type) -> float: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The parameter car
in the calculate_washing_price
method should have a type hint of Car
instead of type
. This ensures that the method expects an instance of the Car
class.
No description provided.