'Solution' #1021
Open
'Solution' #1021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dimosphen1
suggested changes
Nov 21, 2023
app/main.py
Outdated
Comment on lines
17
to
21
| counter = 0 | ||
| for i in phrase: | ||
| if i.lower() == letter.lower(): | ||
| counter += 1 | ||
| return counter |
There was a problem hiding this comment.
Do not use single-letter variable names in your code, be more explicit in naming. Besides that, you could implement this task in one line using chaining and built-in string methods.
viktoria-rybenchuk
suggested changes
Nov 22, 2023
app/main.py
Outdated
Comment on lines
17
to
21
| counter = 0 | ||
| for char in phrase: | ||
| if char.lower() == letter.lower(): | ||
| counter += 1 | ||
| return counter |
There was a problem hiding this comment.
try to write this code in one line
There was a problem hiding this comment.
This block of code can be expressed more concisely in one line using count method of str.
viktoria-rybenchuk
suggested changes
Dec 1, 2023
app/main.py
Outdated
Comment on lines
17
to
21
| counter = 0 | ||
| for char in phrase: | ||
| if char.lower() == letter.lower(): | ||
| counter += 1 | ||
| return counter |
There was a problem hiding this comment.
This block of code can be expressed more concisely in one line using count method of str.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.