Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #1953

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Solution #1953

wants to merge 3 commits into from

Conversation

Mazurkav
Copy link

@Mazurkav Mazurkav commented Nov 9, 2024

No description provided.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Hello! 😊 It looks like the core functionality of your task hasn't been implemented yet. The count_occurrences function is defined but lacks the necessary logic to count occurrences of a letter in a phrase in a case-insensitive manner. Here are a few key points to address:

  1. Function Implementation: Please implement the logic within the count_occurrences function to ensure it counts the occurrences of a specified letter in the given phrase.

  2. Case Insensitivity: Make sure to handle case insensitivity by converting both the phrase and the letter to the same case using methods like str.lower() or str.upper().

  3. Utilize Built-in Functions: Consider using Python's built-in string methods to achieve this task efficiently without loops.

Once these changes are made, your solution will meet the task requirements. Keep up the great work, and don't hesitate to reach out if you have any questions! 🚀

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review button in the Reviewers tab.

app/main.py Show resolved Hide resolved
Copy link
Author

@Mazurkav Mazurkav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code is changed

@Mazurkav Mazurkav closed this Nov 9, 2024
Copy link

@pavlopro pavlopro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests Failed

@Mazurkav Mazurkav requested a review from pavlopro December 22, 2024 12:20
Copy link
Contributor

@vsmutok vsmutok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants