Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

function count_occurrances return the number of times a letter appear… #2028

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ihorhalyskiy
Copy link

function count_occurrances return the number of times a letter appears in a phrase, regardless of case..

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on implementing the count_occurrences function! 🎉 It works perfectly and meets all the requirements. There's just a tiny typo in the docstring that you might want to fix: change 'Yhe' to 'The'. Keep up the excellent work! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

app/main.py Outdated
Count the occurrences of a letter in a phrase ( case-insensitive)
:param phrase: The phrase to search to within
:param letter: The letter to count occurrences of
:return: Yhe number of time the letter appears in the phrase

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a typo in the docstring: 'Yhe' should be corrected to 'The'.

Copy link

@L1nk3rrr L1nk3rrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your code is good structured, nice documented, and ready for use.
Very pythonic and simple solution, well done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants