Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add count occurrences loop #2038

Closed
wants to merge 2 commits into from
Closed

Conversation

Arsenmyron
Copy link

No description provided.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello! 😊 It looks like there's a small but important issue in your code that needs to be addressed before we can approve the pull request. The comparison logic in your count_occurrences function is not working as intended due to a missing method call. Specifically, letter.lower should be letter.lower() to ensure both char and letter are compared in lowercase. This is crucial for the function to handle case insensitivity correctly. Additionally, consider using Python's built-in string functions like str.count() to simplify your code and avoid loops, as recommended. Keep up the great work, and I'm confident you'll nail it with these adjustments! 🚀

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review button in the Reviewers tab.

app/main.py Outdated Show resolved Hide resolved
Copy link
Author

@Arsenmyron Arsenmyron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@Arsenmyron Arsenmyron closed this Nov 25, 2024
@Arsenmyron Arsenmyron deleted the develop branch November 25, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants