completed the task , py-count-occurences #678
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArsenPidhoretskyi
suggested changes
Jul 1, 2023
app/main.py
Outdated
| @@ -14,4 +14,8 @@ def count_occurrences(phrase: str, letter: str) -> int: | |||
| :param letter: letter to find occurrences of it | |||
| :return: count occurrences of letter in phrase | |||
| """ | |||
| # write your code here | |||
| count = 0 | |||
| for i in range(len(phrase)): | |||
There was a problem hiding this comment.
You can iterate through elements instead of indexes
|
Edit solutions |
ArsenPidhoretskyi
suggested changes
Sep 16, 2023
app/main.py
Outdated
Comment on lines
2
to
6
| count = 0 | ||
| for char in phrase: | ||
| if char.lower() == letter.lower(): | ||
| count += 1 | ||
| return count |
There was a problem hiding this comment.
You can write this inline instead of loop
vasylhnatiuk
suggested changes
Sep 27, 2023
app/main.py
Outdated
| # write your code here | ||
| """"" | ||
|
|
||
| return sum(1 for i in phrase if i.lower() == letter.lower()) |
There was a problem hiding this comment.
what is i? use more accurate name
vsmutok
suggested changes
Sep 27, 2023
app/main.py
Outdated
Comment on lines
18
to
19
| return sum(1 for character in phrase | ||
| if character.lower() == letter.lower()) |
There was a problem hiding this comment.
no need to use sum use count
Yurnerroo
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.