Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #1644

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
67 changes: 65 additions & 2 deletions app/main.py
Original file line number Diff line number Diff line change
@@ -1,3 +1,66 @@
class Distance:
# Write your code here
pass
def __init__(self, km: int):
self.km = km
def __repr__(self):
return f"Distance(km={self.km})"
def __str__(self):
return f"Distance: {self.km} kilometers."

def __add__(self, other):
return Distance(
km=self.km + other.km
)

def __iadd__(self, other):
if isinstance(other, Distance):
self.km += other.km
return self
elif isinstance(other, int):
self.km += other
return self

def __mul__(self, other):
if isinstance(other, Distance):
self.km *= other.km
return self
elif isinstance(other, int):
self.km *= other
return self

def __truediv__(self, other):
if isinstance(other, Distance):
self.km = round(self.km / other.km, 2)
return self, 2

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The __truediv__ method is returning a tuple (self, 2) when dividing by another Distance object. This seems incorrect as it should return only self after performing the division. The 2 appears to be mistakenly included.

elif isinstance(other, int):
self.km = round(self.km / other, 2)
return self

def __lt__(self, other):
if isinstance(other, Distance):
return self.km < other.km
elif isinstance(other, int):
return self.km < other

def __gt__(self, other):
if isinstance(other, Distance):
return self.km > other.km
elif isinstance(other, int):
return self.km > other

def __eq__(self, other):
if isinstance(other, Distance):
return self.km == other.km
elif isinstance(other, int):
return self.km == other

def __le__(self, other):
if isinstance(other, Distance):
return self.km != other.km

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The __le__ method is using != instead of <=. This is a logical error as __le__ should implement the 'less than or equal to' comparison, not 'not equal to'.

elif isinstance(other, int):
return self.km != other

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to the previous comment, the __le__ method should use <= instead of != for comparing with an integer.


def __ge__(self, other):
if isinstance(other, Distance):
return self.km >= other.km
elif isinstance(other, int):
return self.km >= other
Loading