Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solution #1665

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
64 changes: 62 additions & 2 deletions app/main.py
Original file line number Diff line number Diff line change
@@ -1,3 +1,63 @@
from typing import Union


class Distance:
# Write your code here
pass
def __init__(self, km: float) -> None:
self.km = km

def __str__(self) -> str:
return f"Distance: {self.km} kilometers."

def __repr__(self) -> str:
return f"Distance(km={self.km})"

def __add__(self, other: Union["Distance", int, float]) -> "Distance":
if isinstance(other, Distance):
return Distance(self.km + other.km)
elif isinstance(other, (int, float)):
return Distance(self.km + other)

def __iadd__(self, other: Union["Distance", int, float]) -> "Distance":
if isinstance(other, Distance):
self.km += other.km
elif isinstance(other, (int, float)):
self.km += other
return self

def __mul__(self, other: Union[int, float]) -> "Distance":
if isinstance(other, (int, float)):
return Distance(self.km * other)
Comment on lines +28 to +29

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The __mul__ method should return NotImplemented if other is not an instance of int or float. This is a good practice to ensure that unsupported operations are handled correctly.


def __truediv__(self, other: Union[int, float]) -> "Distance":
if isinstance(other, (int, float)):
return Distance(round(self.km / other, 2))
Comment on lines +32 to +33

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no check for division by zero in the __truediv__ method. This can lead to a runtime error if other is zero. Consider adding a check to handle this case appropriately.


def __lt__(self, other: Union["Distance", int, float]) -> bool:
if isinstance(other, Distance):
return self.km < other.km
elif isinstance(other, (int, float)):
return self.km < other

def __gt__(self, other: Union["Distance", int, float]) -> bool:
if isinstance(other, Distance):
return self.km > other.km
elif isinstance(other, (int, float)):
return self.km > other

def __eq__(self, other: Union["Distance", int, float]) -> bool:
if isinstance(other, Distance):
return self.km == other.km
elif isinstance(other, (int, float)):
return self.km == other

def __le__(self, other: Union["Distance", int, float]) -> bool:
if isinstance(other, Distance):
return self.km <= other.km
elif isinstance(other, (int, float)):
return self.km <= other

def __ge__(self, other: Union["Distance", int, float]) -> bool:
if isinstance(other, Distance):
return self.km >= other.km
elif isinstance(other, (int, float)):
return self.km >= other
Loading