Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #1671

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Solution #1671

wants to merge 2 commits into from

Conversation

YBlck
Copy link

@YBlck YBlck commented Jan 9, 2025

Distance class task solution

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on implementing the Distance class! 🎉 Your code meets all the task requirements and constraints effectively. While there are a couple of minor improvements suggested, such as handling division by zero in the __truediv__ method and ensuring type checks in the __mul__ method, these do not detract from the overall functionality of your solution. Keep up the excellent work, and consider these suggestions for future enhancements! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

app/main.py Outdated Show resolved Hide resolved
app/main.py Outdated Show resolved Hide resolved
@YBlck YBlck closed this Jan 9, 2025
@YBlck YBlck reopened this Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants