Solution #1672
Solution #1672
Conversation
There was a problem hiding this comment.
Thank you for your hard work on this implementation! 😊 There are a few critical issues that need to be addressed to ensure the functionality of the Distance class is correct:
-
Comparison Methods: The comparison methods (
__lt__,__gt__,__eq__,__le__,__ge__) currently have incorrect logic when comparingDistanceobjects. Make sure to compare thekmattributes of theDistanceobjects (e.g.,self.km < other.km) rather than comparing the object itself. -
Return Types: The return types for the comparison methods should be
bool, notfloat. These methods should return a boolean value indicating the result of the comparison. -
Division by Zero: Ensure that the
__truediv__method checks for division by zero to prevent runtime errors.
Once these issues are resolved, your code will be in great shape! Keep up the great work, and don't hesitate to reach out if you have any questions or need further assistance. 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review button in the Reviewers tab.
app/main.py
Outdated
| result_km = round(self.km / other, 2) | ||
| return Distance(result_km) | ||
|
|
||
| def __lt__(self, other: float) -> float: |
There was a problem hiding this comment.
The return type of __lt__ should be bool, not float. This method should return a boolean indicating if the current instance is less than the other.
app/main.py
Outdated
| if isinstance(other, Distance): | ||
| return self.km < other |
There was a problem hiding this comment.
When comparing with another Distance object, you should compare self.km < other.km instead of self.km < other.
app/main.py
Outdated
| if isinstance(other, Distance): | ||
| return self.km < other | ||
|
|
||
| def __gt__(self, other: float) -> float: |
There was a problem hiding this comment.
The return type of __gt__ should be bool, not float. This method should return a boolean indicating if the current instance is greater than the other.
app/main.py
Outdated
| if isinstance(other, Distance): | ||
| return self.km > other |
There was a problem hiding this comment.
When comparing with another Distance object, you should compare self.km > other.km instead of self.km > other.
app/main.py
Outdated
| if isinstance(other, Distance): | ||
| return self.km > other | ||
|
|
||
| def __eq__(self, other: float) -> float: |
There was a problem hiding this comment.
The return type of __eq__ should be bool, not float. This method should return a boolean indicating if the current instance is equal to the other.
app/main.py
Outdated
| if isinstance(other, Distance): | ||
| return self.km == other |
There was a problem hiding this comment.
When comparing with another Distance object, you should compare self.km == other.km instead of self.km == other.
app/main.py
Outdated
| if isinstance(other, Distance): | ||
| return self.km == other | ||
|
|
||
| def __le__(self, other: float) -> float: |
There was a problem hiding this comment.
The return type of __le__ should be bool, not float. This method should return a boolean indicating if the current instance is less than or equal to the other.
app/main.py
Outdated
| if isinstance(other, Distance): | ||
| return self.km <= other |
There was a problem hiding this comment.
When comparing with another Distance object, you should compare self.km <= other.km instead of self.km <= other.
app/main.py
Outdated
| if isinstance(other, Distance): | ||
| return self.km <= other | ||
|
|
||
| def __ge__(self, other: float) -> float: |
There was a problem hiding this comment.
The return type of __ge__ should be bool, not float. This method should return a boolean indicating if the current instance is greater than or equal to the other.
app/main.py
Outdated
| if isinstance(other, Distance): | ||
| return self.km >= other |
There was a problem hiding this comment.
When comparing with another Distance object, you should compare self.km >= other.km instead of self.km >= other.
There was a problem hiding this comment.
Review Summary
Great effort on implementing the Distance class! 🎉 While your solution is on the right track, there are a few important issues that need attention to ensure the class functions correctly and adheres to the task requirements:
-
Constructor Type Annotation: The
__init__method should have the parameterkmannotated asfloatorintinstead ofbool. This will ensure that the class handles distance values appropriately. -
Division by Zero Check: In the
__truediv__method, it's crucial to add a check to prevent division by zero. This will help avoid runtime errors and make your code more robust. -
Comparison Methods Type Annotations: The parameter
otherin the comparison methods (__lt__,__gt__,__eq__,__le__,__ge__) should be annotated asDistance,int, orfloat, notbool. This will ensure that comparisons are made correctly.
These issues are important for the functionality of your code, so please take the time to review and address them. Remember, learning from these improvements will help you grow as a developer. Keep up the good work, and don't hesitate to reach out if you have any questions! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| class Distance: | ||
| # Write your code here | ||
| pass | ||
| def __init__(self, km: bool) -> None: |
There was a problem hiding this comment.
The constructor parameter km should be of type float or int, not bool. This is likely a mistake in the type annotation.
| def __truediv__(self, other: Distance) -> Distance: | ||
| if isinstance(other, (int, float)): | ||
| result_km = round(self.km / other, 2) | ||
| return Distance(result_km) |
There was a problem hiding this comment.
The __truediv__ method should include a check to prevent division by zero when other is zero. This will prevent runtime errors.
| result_km = round(self.km / other, 2) | ||
| return Distance(result_km) | ||
|
|
||
| def __lt__(self, other: bool) -> bool: |
There was a problem hiding this comment.
The parameter other in the comparison methods should be of type Distance, int, or float, not bool. This is likely a mistake in the type annotation.
| if isinstance(other, Distance): | ||
| return self.km < other.km | ||
|
|
||
| def __gt__(self, other: bool) -> bool: |
There was a problem hiding this comment.
The parameter other in the comparison methods should be of type Distance, int, or float, not bool. This is likely a mistake in the type annotation.
| if isinstance(other, Distance): | ||
| return self.km > other.km | ||
|
|
||
| def __eq__(self, other: bool) -> bool: |
There was a problem hiding this comment.
The parameter other in the comparison methods should be of type Distance, int, or float, not bool. This is likely a mistake in the type annotation.
| if isinstance(other, Distance): | ||
| return self.km == other.km | ||
|
|
||
| def __le__(self, other: bool) -> bool: |
There was a problem hiding this comment.
The parameter other in the comparison methods should be of type Distance, int, or float, not bool. This is likely a mistake in the type annotation.
| if isinstance(other, Distance): | ||
| return self.km <= other.km | ||
|
|
||
| def __ge__(self, other: bool) -> bool: |
There was a problem hiding this comment.
The parameter other in the comparison methods should be of type Distance, int, or float, not bool. This is likely a mistake in the type annotation.
No description provided.