123 #1674
123 #1674
Conversation
There was a problem hiding this comment.
Great job on implementing the Distance class with all the required functionalities! 🎉 The code meets the task requirements and constraints effectively. While there are some minor issues with return type annotations for certain methods, these do not impact the overall functionality. Correcting these annotations will enhance code clarity and correctness. Keep up the good work and continue refining your skills! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| def __init__(self, km: float) -> None: | ||
| self.km = km | ||
|
|
||
| def __str__(self) -> None: |
There was a problem hiding this comment.
The __str__ method should return a str, not None. Update the return type annotation to str.
| def __str__(self) -> None: | ||
| return f"Distance: {self.km} kilometers." | ||
|
|
||
| def __repr__(self) -> None: |
There was a problem hiding this comment.
The __repr__ method should return a str, not None. Update the return type annotation to str.
| raise ZeroDivisionError("Cannot divide by zero.") | ||
| return NotImplemented | ||
|
|
||
| def __lt__(self, other: "Distance") -> "Distance": |
There was a problem hiding this comment.
The __lt__ method should return a bool, not Distance. Update the return type annotation to bool.
| return self.km < other | ||
| return NotImplemented | ||
|
|
||
| def __gt__(self, other: "Distance") -> "Distance": |
There was a problem hiding this comment.
The __gt__ method should return a bool, not Distance. Update the return type annotation to bool.
| return self.km > other | ||
| return NotImplemented | ||
|
|
||
| def __eq__(self, other: "Distance") -> "Distance": |
There was a problem hiding this comment.
The __eq__ method should return a bool, not Distance. Update the return type annotation to bool.
| return self.km == other | ||
| return NotImplemented | ||
|
|
||
| def __le__(self, other: "Distance") -> "Distance": |
There was a problem hiding this comment.
The __le__ method should return a bool, not Distance. Update the return type annotation to bool.
| return self.km <= other | ||
| return NotImplemented | ||
|
|
||
| def __ge__(self, other: "Distance") -> "Distance": |
There was a problem hiding this comment.
The __ge__ method should return a bool, not Distance. Update the return type annotation to bool.
No description provided.