Solution #1681
Solution #1681
Conversation
There was a problem hiding this comment.
Great job on implementing the Distance class! 🎉 Your code meets all the task requirements and constraints, and the functionality is well-executed. While there's a minor suggestion to enhance robustness by adding type checks in the __add__ method, it doesn't impact the core functionality. Keep up the great work and consider this improvement for future projects to make your code even more robust! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| def __add__(self, other: "Distance") -> "Distance": | ||
| other_km = other if isinstance(other, (int, float)) else other.km |
There was a problem hiding this comment.
The __add__ method assumes other is either a Distance object or a numeric type. If other is neither, this could lead to unexpected behavior. Consider adding a type check or raising an error if other is not a valid type.
Solution for py-distance-class