[IMP] (develop): Task - py_distance_class #1684
Conversation
There was a problem hiding this comment.
Great job on implementing the Distance class! 🎉 The functionality is solid and meets the task requirements. While there are some minor inconsistencies in the type hints, they don't impact the core functionality. Keep up the good work, and consider refining the type hints for even better code clarity in the future! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| def __repr__(self) -> str: | ||
| return f"Distance(km={self.km})" | ||
|
|
||
| def __add__(self, other: float) -> "Distance": |
There was a problem hiding this comment.
The type hint for the other parameter in the __add__ method should be Union[Distance, int, float] instead of just float to accurately reflect the types that this method can handle.
| else: | ||
| raise TypeError("Unsupported operand type(s) for +") | ||
|
|
||
| def __iadd__(self, other: float) -> "Distance": |
There was a problem hiding this comment.
The type hint for the other parameter in the __iadd__ method should be Union[Distance, int, float] instead of just float to accurately reflect the types that this method can handle.
| raise TypeError("Unsupported operand type(s) for +=") | ||
| return self | ||
|
|
||
| def __mul__(self, other: "Distance") -> "Distance": |
There was a problem hiding this comment.
The type hint for the other parameter in the __mul__ method should be Union[int, float] instead of Distance to accurately reflect the types that this method can handle.
| else: | ||
| raise TypeError("Unsupported operand type(s) for *") | ||
|
|
||
| def __truediv__(self, other: "Distance") -> "Distance": |
There was a problem hiding this comment.
The type hint for the other parameter in the __truediv__ method should be Union[int, float] instead of Distance to accurately reflect the types that this method can handle.
| else: | ||
| raise TypeError("Unsupported operand type(s) for /") | ||
|
|
||
| def __eq__(self, other: float) -> bool: |
There was a problem hiding this comment.
The type hint for the other parameter in the __eq__ method should be Union[Distance, int, float] instead of just float to accurately reflect the types that this method can handle.
| else: | ||
| return NotImplemented | ||
|
|
||
| def __gt__(self, other: float) -> bool: |
There was a problem hiding this comment.
The type hint for the other parameter in the __gt__ method should be Union[Distance, int, float] instead of just float to accurately reflect the types that this method can handle.
| else: | ||
| return NotImplemented | ||
|
|
||
| def __ge__(self, other: float) -> bool: |
There was a problem hiding this comment.
The type hint for the other parameter in the __ge__ method should be Union[Distance, int, float] instead of just float to accurately reflect the types that this method can handle.
| else: | ||
| return NotImplemented | ||
|
|
||
| def __lt__(self, other: float) -> bool: |
There was a problem hiding this comment.
The type hint for the other parameter in the __lt__ method should be Union[Distance, int, float] instead of just float to accurately reflect the types that this method can handle.
| else: | ||
| return NotImplemented | ||
|
|
||
| def __le__(self, other: float) -> bool: |
There was a problem hiding this comment.
The type hint for the other parameter in the __le__ method should be Union[Distance, int, float] instead of just float to accurately reflect the types that this method can handle.
No description provided.