Solution #423
Open
Solution #423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Abnormaltype
suggested changes
Mar 1, 2023
app/main.py
Outdated
| class Distance: | ||
| # Write your code here | ||
| pass | ||
| def __init__(self, km: any) -> None: |
There was a problem hiding this comment.
put the correct type annotation
There was a problem hiding this comment.
not fixed it can be float | int
app/main.py
Outdated
| def __repr__(self) -> str: | ||
| return f"Distance(km={self.km})" | ||
|
|
||
| def __add__(self, other: any) -> Distance: |
There was a problem hiding this comment.
put the correct type annotation
app/main.py
Outdated
Comment on lines
22
to
66
| def __iadd__(self, other: any) -> Distance: | ||
| if isinstance(other, Distance): | ||
| self.km += other.km | ||
| return self | ||
| else: | ||
| self.km += other | ||
| return self | ||
|
|
||
| def __mul__(self, other: any) -> Distance: | ||
| self.km = self.km * other | ||
| return self | ||
|
|
||
| def __truediv__(self, other: any) -> Distance: | ||
| self.km = round(self.km / other, 2) | ||
| return self | ||
|
|
||
| def __lt__(self, other: any) -> bool: | ||
| if isinstance(other, Distance): | ||
| return self.km < other.km | ||
| else: | ||
| return self.km < other | ||
|
|
||
| def __gt__(self, other: any) -> bool: | ||
| if isinstance(other, Distance): | ||
| return self.km > other.km | ||
| else: | ||
| return self.km > other | ||
|
|
||
| def __eq__(self, other: any) -> bool: | ||
| if isinstance(other, Distance): | ||
| return self.km == other.km | ||
| else: | ||
| return self.km == other | ||
|
|
||
| def __le__(self, other: any) -> bool: | ||
| if isinstance(other, Distance): | ||
| return self.km <= other.km | ||
| else: | ||
| return self.km <= other | ||
|
|
||
| def __ge__(self, other: any) -> bool: | ||
| if isinstance(other, Distance): | ||
| return self.km >= other.km | ||
| else: | ||
| return self.km >= other |
There was a problem hiding this comment.
put the correct type annotation
There was a problem hiding this comment.
I don't understand why annotations type is wrong?
vsmutok
suggested changes
Oct 18, 2023
app/main.py
Outdated
| def __ge__(self, other: any) -> bool: | ||
| if isinstance(other, Distance): | ||
| return self.km >= other.km | ||
| else: |
app/main.py
Outdated
| else: | ||
| return self.km <= other | ||
|
|
||
| def __ge__(self, other: any) -> bool: |
There was a problem hiding this comment.
Suggested change
| def __ge__(self, other: any) -> bool: | |
| def __ge__(self, other: Distance | int | float) -> bool: |
ArsenPidhoretskyi
suggested changes
Oct 19, 2023
app/main.py
Outdated
| class Distance: | ||
| # Write your code here | ||
| pass | ||
| def __init__(self, km: any) -> None: |
There was a problem hiding this comment.
not fixed it can be float | int
app/main.py
Outdated
| return self | ||
| else: | ||
| self.km += other | ||
| return self |
| return f"Distance(km={self.km})" | ||
|
|
||
| def __add__(self, other: Distance | int | float) -> Distance: | ||
| if isinstance(other, Distance): |
There was a problem hiding this comment.
add must create new instance instead of change current
app/main.py
Outdated
| return self | ||
|
|
||
| def __mul__(self, other: Distance | int | float) -> Distance: | ||
| self.km = self.km * other |
There was a problem hiding this comment.
mul must create new instance instead of change current
app/main.py
Outdated
| return self | ||
|
|
||
| def __truediv__(self, other: Distance | int | float) -> Distance: | ||
| self.km = round(self.km / other, 2) |
There was a problem hiding this comment.
truediv must create new instance instead of change current
app/main.py
Outdated
| def __ge__(self, other: any) -> bool: | ||
| if isinstance(other, Distance): | ||
| return self.km >= other.km | ||
| else: |
Yurnerroo
suggested changes
Oct 19, 2023
app/main.py
Outdated
Comment on lines
22
to
26
| if isinstance(other, Distance): | ||
| self.km += other.km | ||
| return self | ||
| self.km += other | ||
| return self |
Yurnerroo
suggested changes
Oct 19, 2023
app/main.py
Outdated
Comment on lines
16
to
19
| km = self.km + other.km | ||
| return Distance(km) | ||
| km = self.km + other | ||
| return Distance(km) |
Yurnerroo
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.