solution #809
Closed
solution #809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dimosphen1
suggested changes
Oct 23, 2023
app/main.py
Outdated
| def __repr__(self) -> str: | ||
| return f"Distance(km={self.km})" | ||
|
|
||
| def __add__(self, other: Any) -> Any: |
There was a problem hiding this comment.
Be more specific in your type annotations and indicate that other could be either an int, float, or Distance instance and that the return type would be always a Distance class instance. Make such changes to other methods where applicable.
app/main.py
Outdated
| return self.km <= other.km | ||
| return self.km <= other | ||
|
|
||
| def __ge__(self, other: Any) -> bool: |
There was a problem hiding this comment.
You could implement some methods based on the implemented functionality of others. E.g. self is greater or equal to other when self is not less than other.
viktoria-rybenchuk
suggested changes
Oct 24, 2023
app/main.py
Outdated
Comment on lines
22
to
25
| self.km += other.km | ||
| return self | ||
| self.km += other | ||
| return self |
There was a problem hiding this comment.
write this code with one return
app/main.py
Outdated
| def __repr__(self) -> str: | ||
| return f"Distance(km={self.km})" | ||
|
|
||
| def __add__(self, other: (int, float, Distance)) -> Distance: |
There was a problem hiding this comment.
Suggested change
| def __add__(self, other: (int, float, Distance)) -> Distance: | |
| def __add__(self, other: int | float | Distance) -> Distance: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.