Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #813

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Solution #813

wants to merge 2 commits into from

Conversation

lyaskov
Copy link

@lyaskov lyaskov commented Oct 24, 2023

No description provided.

app/main.py Outdated
Comment on lines 17 to 18
else:
return Distance(self.km + other)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code block is redundant

app/main.py Outdated
Comment on lines 15 to 18
if isinstance(other, Distance):
return Distance(self.km + other.km)
else:
return Distance(self.km + other)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if isinstance(other, Distance):
return Distance(self.km + other.km)
else:
return Distance(self.km + other)
if isinstance(other, Distance):
return Distance(self.km + other.km)
return Distance(self.km + other)

app/main.py Outdated
Comment on lines 38 to 39
else:
return self.km < other

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same comment as above

app/main.py Outdated
Comment on lines 44 to 45
else:
return self.km > other

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same comment as above

app/main.py Outdated
Comment on lines 50 to 51
else:
return self.km == other

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same comment as above

app/main.py Outdated
Comment on lines 56 to 57
else:
return self.km <= other

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same comment as above

app/main.py Outdated
Comment on lines 62 to 63
else:
return self.km >= other

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same comment as above

@lyaskov lyaskov requested a review from EdAlekseiev October 24, 2023 18:53
Copy link

@EdAlekseiev EdAlekseiev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants