'solution' #820
Open
'solution' #820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EdAlekseiev
suggested changes
Oct 27, 2023
app/main.py
Outdated
| def __repr__(self) -> str: | ||
| return f"Distance(km={self.km})" | ||
|
|
||
| def __lt__(self, other: int) -> bool: |
There was a problem hiding this comment.
other can be float and Distance too. Please, rewrite your functions.
ArsenPidhoretskyi
suggested changes
Oct 27, 2023
app/main.py
Outdated
| return f"Distance(km={self.km})" | ||
|
|
||
| def __lt__(self, other: int | float | Distance) -> bool: | ||
| return True if self.km < other else False |
There was a problem hiding this comment.
In this case you can do
Suggested change
| return True if self.km < other else False | |
| return self.km < other |
Fix in all places
app/main.py
Outdated
| def __iadd__(self, other: int | float | Distance) -> Distance: | ||
| if isinstance(other, (int, float)): | ||
| self.km += other | ||
| return self |
There was a problem hiding this comment.
Move return after if-else statement
NikOneZ1
suggested changes
Oct 27, 2023
app/main.py
Outdated
Comment on lines
46
to
47
| def __mul__(self, other: int | float | Distance) -> Distance: | ||
| return Distance(self.km * other) |
There was a problem hiding this comment.
You need to check if the other is a distance, or an int, or a float. If it's an instance of distance, then you'll have to operate with other, not just other. Do it in other function too.
Suggested change
| def __mul__(self, other: int | float | Distance) -> Distance: | |
| return Distance(self.km * other) | |
| def __mul__(self, other: int | float | Distance) -> Distance: | |
| if isinstance(other, Distance): | |
| return Distance(self.km * other.km) | |
| return Distance(self.km * other) |
EdAlekseiev
suggested changes
Oct 28, 2023
app/main.py
Outdated
| def __truediv__(self, other: int | float | Distance) -> Distance: | ||
| return Distance(round(self.km / other, 2)) | ||
|
|
||
| def __mul__(self, other: int | float | Distance) -> Distance: |
There was a problem hiding this comment.
other can't be Distance in this function
app/main.py
Outdated
| def __truediv__(self, other: int | float | Distance) -> Distance: | ||
| return Distance(round(self.km / other, 2)) | ||
|
|
||
| def __mul__(self, other: int | float | Distance) -> Distance: |
There was a problem hiding this comment.
Suggested change
| def __mul__(self, other: int | float | Distance) -> Distance: | |
| def __mul__(self, other: int | float) -> Distance: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.