Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #827

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
64 changes: 62 additions & 2 deletions app/main.py
Original file line number Diff line number Diff line change
@@ -1,3 +1,63 @@
from __future__ import annotations


class Distance:
# Write your code here
pass
def __init__(self, km: float | int) -> None:
self.km = km

def __str__(self) -> str:
return f"Distance: {self.km} kilometers."

def __repr__(self) -> str:
return f"Distance(km={self.km})"

def __add__(self, other: int | float | Distance) -> Distance:
if isinstance(other, Distance):
return Distance(self.km + other.km)
elif isinstance(other, (int, float)):
return Distance(self.km + other)

def __iadd__(self, other: int | float | Distance) -> Distance:
if isinstance(other, Distance):
self.km += other.km
elif isinstance(other, (int, float)):
self.km += other
else:
raise TypeError("Unsupported operand type")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why in some methods you raise TypeError if the operand is not of an expected type but in the others not? like def add or def truediv? try to be consistent, but you can avoid raising this error

return self

def __mul__(self, scalar: int | float) -> Distance:
if isinstance(scalar, (int, float)):
return Distance(self.km * scalar)
else:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

redundant else

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed!

raise TypeError("Unsupported operand type")

def __truediv__(self, divisor: int | float) -> Distance:
if isinstance(divisor, (int, float)):
return Distance(round(self.km / divisor, 2))

def __lt__(self, other: int | float) -> bool:
return (
self.km < other.km if isinstance(other, Distance)
else self.km < other
)

def __gt__(self, other: int | float) -> bool:
if isinstance(other, Distance):
return self.km > other.km
return self.km > other

def __eq__(self, other: int | float) -> bool:
if isinstance(other, Distance):
return self.km == other.km
return self.km == other

def __le__(self, other: int | float) -> bool:
if isinstance(other, Distance):
return self.km <= other.km
return self.km <= other

def __ge__(self, other: int | float) -> bool:
if isinstance(other, Distance):
return self.km >= other.km
return self.km >= other