'Solution' #830
'Solution' #830
Conversation
|
|
||
| def __truediv__(self, other: float) -> object: | ||
| return Distance(round(self.km / other, 2)) | ||
|
|
There was a problem hiding this comment.
in mul and truediv methods other can be int or float, in the rest of the methods int, float or an instance of the Distance class.
Add logic to handle cases when other is an instance of the Distance class and fix type hints.
There was a problem hiding this comment.
I avoided unnecessary logic, as I was advised last time, there were 110 questions in the test, which my solution passed successfully, how can I understand where the logic is excessive and where it is insufficient?
app/main.py
Outdated
| def __repr__(self) -> str: | ||
| return f"Distance(km={self.km})" | ||
|
|
||
| def __add__(self, other: Union[int, float, "Distance"]) -> object: |
There was a problem hiding this comment.
Change your type annotation to use the latest syntaxis. Besides that, be more specific in the return type annotation, in Python everything is an object:
| def __add__(self, other: Union[int, float, "Distance"]) -> object: | |
| def __add__(self, other: int | float | Distance) -> Distance: |
Apply this change to all places where applicable. In case you face incompatibility errors, use from __future__ import annotation.
No description provided.