Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution-Is_isogram #357

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ArtemYukhymenko
Copy link

No description provided.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on your solution! 🎉 Your code meets the task requirements and constraints effectively, and the test cases are comprehensive, covering a wide range of scenarios. However, there's a minor point to consider: the test case for words with spaces or special characters assumes these should be treated as repeating letters. If the function should ignore them, you might want to adjust this test case. Keep up the great work and happy coding! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

Comment on lines +47 to +49
it(`should return false for words containing spaces or special
characters as repeating letters`, () => {
expect(isIsogram('hello world')).toBe(false);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test case for words containing spaces or special characters assumes that these characters should be considered as repeating letters. If the isIsogram function is supposed to ignore spaces and special characters, this test case should be adjusted to reflect that behavior. Consider clarifying the expected behavior of the isIsogram function regarding spaces and special characters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants