Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add solution #2911

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add solution #2911

wants to merge 1 commit into from

Conversation

artuom2283
Copy link

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on your submission! 🎉 The code is well-structured and meets the task requirements. While there are a couple of minor improvements suggested, such as verifying the UserInfo component's implementation and considering the removal of the unnecessary name property in TodoProps, these do not impact the functionality. Keep up the good work and continue refining your skills! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

title: string;
userId: number;
completed: boolean;
name: string;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name property in TodoProps might be unnecessary since the name is derived from the user data when creating a new todo. Consider removing it from the TodoProps type.

<option value="0" disabled>
Choose a user
</option>
<UserInfo users={usersFromServer} />

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The UserInfo component is used here as if it returns a list of <option> elements. Ensure that UserInfo is implemented to return the correct JSX structure for rendering user options. If UserInfo is not a component that returns JSX options, you may need to map over usersFromServer directly to generate the <option> elements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants