solution #2914
solution #2914
Conversation
There was a problem hiding this comment.
Great job on implementing the task! 🎉 While there are a few minor issues, such as the incorrect calculation of the new id, a typo in the state variable name, and the handling of missing user data, these do not significantly impact the functionality. Keep up the good work and consider these suggestions for future improvements! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| const [userId, setUserId] = useState(0); | ||
|
|
||
| const [titleError, setTitleError] = useState(false); | ||
| const [useError, setUseError] = useState(false); |
There was a problem hiding this comment.
There is a typo in the state variable name useError. It should likely be userError to accurately reflect its purpose of handling user selection errors.
| } | ||
|
|
||
| const newTodo: Todo = { | ||
| id: Math.max(...todos.map(todo => todo.id + 1)), |
There was a problem hiding this comment.
The calculation for the new id is incorrect. The expression Math.max(...todos.map(todo => todo.id + 1)) will add 1 to each id before finding the maximum, which is not the intended behavior. Instead, find the maximum id first, then add 1 to it.
| name: user?.name || 'Empty', | ||
| email: user?.email || '', |
There was a problem hiding this comment.
When a user is not found, the default name is set to 'Empty' and the email to an empty string. While this handles the case where a user might not be found, it might be more informative to use a placeholder like 'Unknown User' or 'No Email' to make it clear that the user data is missing.
DEMO LINK