-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
need to add UserInfo class #2927
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job on implementing the task! 🎉 While there are a few minor issues like typos in function names and accessibility improvements, they don't significantly impact the functionality. Keep up the good work and consider addressing these minor points for even cleaner code in the future! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
<span className="error">Please choose a user</span> | ||
</div> | ||
const [usersList] = useState<User[]>(usersFromServer); | ||
const [todoList, setuTodoList] = useState<Todo[]>(todosFromServer); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The function name setuTodoList
seems to be a typo. It should likely be setTodoList
to match the naming convention and improve code readability.
const [titleError, setTitleError] = useState(false); | ||
const [userError, setUserError] = useState(false); | ||
|
||
function onSubmitChacge(event: React.FormEvent) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The function name onSubmitChacge
seems to be a typo. It should likely be onSubmitChange
to match the intended functionality.
</div> | ||
|
||
<div className="field"> | ||
<label htmlFor=""> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The htmlFor
attribute in the label should match the id
of the select element for better accessibility. Consider adding an id
to the select element and updating this attribute accordingly.
DEMO LINK