Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

task #3385

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

task #3385

wants to merge 1 commit into from

Conversation

OlegMysko
Copy link

@OlegMysko OlegMysko commented Feb 15, 2025

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! 🎉 Your implementation of the Sum component correctly handles missing props by defaulting them to 0, and the App component uses the Sum component as specified. Keep up the good work!

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

<p>Sum of 0 and 0 is 0</p>
<Sum a={2} b={3} />
<Sum a={-5} b={5} />
<Sum a={10} />

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Sum component is missing the b prop. According to the task description, if a or b props are not passed, they should default to 0. Ensure that the Sum component handles this correctly by setting default values for missing props.

<Sum a={2} b={3} />
<Sum a={-5} b={5} />
<Sum a={10} />
<Sum b={5} />

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Sum component is missing the a prop. Ensure that the Sum component handles missing props by setting them to 0 as per the task description.

<Sum a={-5} b={5} />
<Sum a={10} />
<Sum b={5} />
<Sum />

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Sum component is missing both a and b props. Ensure that the Sum component handles missing props by setting them to 0 as per the task description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants